Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The major renderer upgrade and higher Safari baseline need compatibility validation in MarkEdit’s supported WebKit hosts.
No open issues 🎉
What changed in this PR
Migrates MarkEdit-preview to Mermaid 12.2, updates its dependencies, and adds coverage for rendering defaults and build variants.
Changes:
- Upgrades Mermaid and its dependency tree, including ELK layout support.
- Raises the build target from Safari 16 to Safari 17.4.
- Adds renderer integration tests and strengthens theme initialization and bundle inclusion checks.
| File | Description |
|---|---|
yarn.lock |
Locks Mermaid 12.2 and updated transitive dependencies. |
vite.config.mts |
Raises the Safari build target to 17.4. |
tests/render.styles.test.ts |
Checks exported HTML theme initialization across color schemes. |
tests/mermaid.integration.test.ts |
Adds real-renderer coverage for diagrams, themes, and legacy appearance options. |
tests/build.test.ts |
Checks ELK inclusion in full builds and exclusion from lite builds. |
package.json |
Updates the Mermaid dependency to ^12.2.0. |
Review effort: Balanced
cyanzhong
force-pushed
the
develop
branch
3 times, most recently
from
October 23, 2026 10:11
bd76865 to
a1f594a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.