Skip to content

MDEV-41161: Add OpenBSD getexecpath() support to my_get_exepath() - #5686

Open
brad0 wants to merge 1 commit into
MariaDB:10.6from
brad0:openbsd_getexecpath
Open

MDEV-41161: Add OpenBSD getexecpath() support to my_get_exepath()#5686
brad0 wants to merge 1 commit into
MariaDB:10.6from
brad0:openbsd_getexecpath

Conversation

@brad0

@brad0 brad0 commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@brad0
brad0 changed the base branch from main to 10.5 September 17, 2026 04:43
@brad0

brad0 commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

I forgot to target the oldest branch not latest (main).

@brad0
brad0 changed the base branch from 10.5 to 10.6 September 17, 2026 04:59
@brad0
brad0 force-pushed the openbsd_getexecpath branch from 201dddd to 13b52ab Compare September 17, 2026 05:02
@gkodinov gkodinov added the External Contribution All PRs from entities outside of MariaDB Foundation, Corporation, Codership agreements. label Sep 17, 2026
gkodinov
gkodinov requested changes Sep 17, 2026
View reviewed changes

@gkodinov gkodinov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! This is a preliminary review.

First of all: can you please describe how this works on the OS prior to your fix and how does your fix change the functionality?
I believe not significantly. But please prove me wrong if it's otherwise.

I need the exact comparison to understand if this is a bug fix or a featurette add-on.

If the belief I've expressed above is even remotely rooted in reality, I'd say that this needs to be rebased on the main branch.

If it's a bug fix, it needs to go to either 11.4 or 10.11 (depending on severity).

Please clarify.

In the meantime, I have some formal suggestions on the diff itself.
And I'd very much appreciate a regression test, even if it is specific to the OS at hand.

Comment thread mysys/my_getexe.c Outdated
Comment thread mysys/my_getexe.c Outdated
@gkodinov gkodinov self-assigned this Sep 17, 2026
@brad0
brad0 force-pushed the openbsd_getexecpath branch from 13b52ab to d90e1af Compare September 17, 2026 08:17
gkodinov
gkodinov requested changes Sep 17, 2026
View reviewed changes

@gkodinov gkodinov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks ok now. Please, as requested, also rebase, think of a possible test case and describe the pre- and post- effects.

@brad0

brad0 commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

3a4bc9a

I don't see any unit tests added or modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gkodinov gkodinov gkodinov requested changes

Assignees

@gkodinov gkodinov

Labels

External Contribution All PRs from entities outside of MariaDB Foundation, Corporation, Codership agreements.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brad0 @gkodinov