Repository navigation
feat(landing): Loguru for Python guide - #1576
Open
JeremyFunk wants to merge 4 commits into
Open
JeremyFunk wants to merge 4 commits into
JeremyFunk wants to merge 4 commits into
Maple Review Bot / Maple / review
completed
Oct 20, 2026 in 39s
Confidence 8/10 · 1 issue to address
🟢 Confidence 8/10 · likely safe to merge
Held at 8 because a warning is open.
1 warning −1 · tests not needed · risk low
The new commit adds the two guide screenshots the figures point at, closing the broken-image finding; nothing else in the file changed. Mergeable except for the /guides/python-logging-levels link, which still 404s until the sibling guide lands.
Still open from earlier reviews
- 🟠 Warning · F1 · Link to
/guides/python-logging-levelshas no page behind it ·apps/landing/src/pages/guides/loguru.astro:561
Fixed since the last review
- ✅
F2 · Both guide screenshots point at files that are not inpublic/
Production impact
Production traffic of the changed files (last 7 days)
| File | Calls/day | Busiest operations |
|---|---|---|
apps/landing/src/pages/guides/loguru.astro |
98k | maple 98k/day, 90.4% err |
Telemetry this change adds and removes (1)
- ➕ span name
POST /checkout·apps/landing/src/pages/guides/loguru.astro:365
Ingest cost of new log lines
apps/landing/src/pages/guides/loguru.astro:58: If this logs once per call, about 798 MB/month: the file's operations run 98k times a day.apps/landing/src/pages/guides/loguru.astro:59: If this logs once per call, about 798 MB/month: the file's operations run 98k times a day.apps/landing/src/pages/guides/loguru.astro:60: If this logs once per call, about 798 MB/month: the file's operations run 98k times a day.apps/landing/src/pages/guides/loguru.astro:62: If this logs once per call, about 798 MB/month: the file's operations run 98k times a day.apps/landing/src/pages/guides/loguru.astro:63: If this logs once per call, about 798 MB/month: the file's operations run 98k times a day.apps/landing/src/pages/guides/loguru.astro:69: If this logs once per call, about 798 MB/month: the file's operations run 98k times a day.apps/landing/src/pages/guides/loguru.astro:70: If this logs once per call, about 798 MB/month: the file's operations run 98k times a day.apps/landing/src/pages/guides/loguru.astro:71: If this logs once per call, about 798 MB/month: the file's operations run 98k times a day.apps/landing/src/pages/guides/loguru.astro:115: If this logs once per call, about 798 MB/month: the file's operations run 98k times a day.apps/landing/src/pages/guides/loguru.astro:158: If this logs once per call, about 798 MB/month: the file's operations run 98k times a day.
What was checked
- Both screenshot paths at loguru.astro:881 and :886 now exist in
apps/landing/public/screenshots/guides/(git ls-tree: 71 KB and 27 KB webp blobs) /guides/python-logging-levels(line 618) still has no page:src/pages/guides/holds no such file at this head
9716c0d · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading