Repository navigation
feat(settings): MCP connected clients and a live tool catalog - #1530
Merged
Merged
Maple Review Bot / Maple / review
succeeded
Oct 17, 2026 in 33s
Confidence 9/10 · No issues found
🟢 Confidence 9/10 · safe to merge
The only delta since the last review is the CFG-SAMP-01 action in setup-health.ts, verified against the DOCS table it now points at.
quality 100/100 · no findings · tests partial · risk low
Since the previous review the only delta is setup-health.ts: CFG-SAMP-01 now sends the user to the sampling docs page instead of the ingestion tab anchor. The link target exists in DOCS, so this is safe to merge.
setupHealthActionreturns a docs action forCFG-SAMP-01instead of a settings-tab link
Production impact
Production traffic of the changed files (last 7 days)
| File | Calls/day | Busiest operations |
|---|---|---|
apps/api/src/worker/ai-forward.ts |
23k | POST /mcp 11k/day, 0.0% errPOST /mcp 11k/day, 0.0% errGET /mcp 722/day, 0.0% err |
apps/ai/src/runtime/http-graph.ts |
135 | POST /internal/triage/classify 91/day, 0.0% errPOST /internal/triage/classify 44/day, 0.0% err |
Telemetry this change adds and removes (3)
- ➕ span name
McpConnectionsService.liveConnections·packages/backend/src/services/auth/McpConnectionsService.ts:88 - ➕ span name
McpConnectionsService.list·packages/backend/src/services/auth/McpConnectionsService.ts:124 - ➕ span name
McpConnectionsService.revoke·packages/backend/src/services/auth/McpConnectionsService.ts:132
What was checked
docsUrl("samplingThroughput")resolves to an existingDOCSentry (apps/web/src/lib/docs.ts:10)- The existing
setupHealthActionregistry test still covers the changed branch (setup-health.test.ts:10)
7ba87e5 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading