Repository navigation
feat(settings): one Keys table and a reshaped Ingestion page - #1528
Merged
Makisuo merged 37 commits intoOct 17, 2026
Merged
Maple Review Bot / Maple / review
succeeded
Oct 17, 2026 in 1m 21s
Confidence 8/10 · No issues found
🟢 Confidence 8/10 · likely safe to merge
Two prior info findings, unchanged in the head, cap it; the sampling reverts are complete and leave no dangling reference.
quality 96/100 · 2 notes · tests partial · risk low
At this head the pull request is only the Keys and Ingestion settings rework — one filterable keys table, a reshaped Ingestion tab. The trace sampling API and Sampling section the title and description promise were reverted and no longer exist, so nothing sampling-related ships here.
buildKeyRows/filterKeyRowsmerge the ingest pair, API and MCP keys into one searchable, type- and status-filtered table- Members get
Create MCP keyand a read-onlyOn/Offcolumn;AdminOnlyNoticereplaces the old per-section footers - Ingestion drops its inline key rows for an
EndpointSectionthat links to the Keys tab - Attribute mappings and recommendations lose their tooltips in favour of an always-visible
RowActionsMenu
Still open from earlier reviews
- 🔵 Note · F2 ·
keyAccessSummaryrenders an empty Access cell for a*-scoped key ·apps/web/src/components/settings/keys-table.ts:176 - 🔵 Note · F4 ·
Ingestchip is offered while the ingest keys are loading or in a status that can never hold them ·apps/web/src/components/settings/api-keys-section.tsx:210
Fixed since the last review
- ✅
F3 ·storedSlowSpansMsreads a stored0as off while the gateway keeps every span - ✅
F5 ·ignores float noisecase cannot exercise the noise it names - ✅
F6 · Client bounds restateTRACE_SAMPLE_RATIO_MINandALWAYS_KEEP_SLOW_SPANS_MS_MAXfrom the domain package
What was checked
- Reverts are complete: no
sampling,trace_samplingorTraceSamplingmatch anywhere at the head commit - The new
search={{ tab: "keys" }}link matches the registered tab id (settings-nav.tsx:31) SCOPE_FAMILY_ROWSmatchesSCOPE_FAMILIESid-for-id, all 18 families
af7d138 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading