Skip to content

feat(settings): one Keys table and a reshaped Ingestion page - #1528

Merged
Makisuo merged 37 commits into
feat/settings-billing-usagefrom
feat/settings-keys-ingestion
Oct 17, 2026
Merged

Makisuo merged 37 commits into
feat/settings-billing-usagefrom
feat/settings-keys-ingestion

revert(settings): drop the trace sampling scope from key creation and…

af7d138
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 17, 2026 in 1m 21s

Confidence 8/10 · No issues found

🟢 Confidence 8/10 · likely safe to merge
Two prior info findings, unchanged in the head, cap it; the sampling reverts are complete and leave no dangling reference.
quality 96/100 · 2 notes · tests partial · risk low

At this head the pull request is only the Keys and Ingestion settings rework — one filterable keys table, a reshaped Ingestion tab. The trace sampling API and Sampling section the title and description promise were reverted and no longer exist, so nothing sampling-related ships here.

  • buildKeyRows/filterKeyRows merge the ingest pair, API and MCP keys into one searchable, type- and status-filtered table
  • Members get Create MCP key and a read-only On/Off column; AdminOnlyNotice replaces the old per-section footers
  • Ingestion drops its inline key rows for an EndpointSection that links to the Keys tab
  • Attribute mappings and recommendations lose their tooltips in favour of an always-visible RowActionsMenu

Still open from earlier reviews

Fixed since the last review

  • ✅ F3 · storedSlowSpansMs reads a stored 0 as off while the gateway keeps every span
  • ✅ F5 · ignores float noise case cannot exercise the noise it names
  • ✅ F6 · Client bounds restate TRACE_SAMPLE_RATIO_MIN and ALWAYS_KEEP_SLOW_SPANS_MS_MAX from the domain package
What was checked
  • Reverts are complete: no sampling, trace_sampling or TraceSampling match anywhere at the head commit
  • The new search={{ tab: "keys" }} link matches the registered tab id (settings-nav.tsx:31)
  • SCOPE_FAMILY_ROWS matches SCOPE_FAMILIES id-for-id, all 18 families

af7d138 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.