Skip to content

feat(settings): redesign General and Members - #1526

Merged
Makisuo merged 17 commits into
feat/settings-redesign-foundationfrom
feat/settings-general-members
Oct 17, 2026
Merged

Makisuo merged 17 commits into
feat/settings-redesign-foundationfrom
feat/settings-general-members

fix(settings): list the history and settings an org delete keeps

1408fd2
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 17, 2026 in 1m 0s

Confidence 8/10 · No issues found

🟢 Confidence 8/10 · likely safe to merge
Since the last review only the deletion-facts copy changed, and I verified it against UNPURGED_ORG_SCOPED_TABLES; the rest was reviewed at 258b767.
quality 100/100 · no findings · tests partial · risk medium

The only change since the last review is the deletion-facts copy: the Kept row now names the retained history and settings, matching UNPURGED_ORG_SCOPED_TABLES. The rest of General and Members was reviewed at 258b767; safe to merge.

Fixed since the last review

  • ✅ F1 · DeletionFacts says only the audit log and billing survive a delete
What was checked
  • The Kept row's five names all appear in UNPURGED_ORG_SCOPED_TABLES (OrganizationService.ts:199)
  • organizationHomeRegion(metadata)[0] always indexes MAPLE_REGION_LABELS (organization-regions.ts:79)
  • handleSaveName still pairs submit() with commit({ submitted, sent }) or abort() (settings-draft.ts:120

1408fd2 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.