Skip to content

feat(web): manage custom ingest keys in ingestion settings - #1520

Closed
Makisuo wants to merge 28 commits into
feat/ingest-keys-custom-gatewayfrom
feat/ingest-keys-custom-ui
Closed

Makisuo wants to merge 28 commits into
feat/ingest-keys-custom-gatewayfrom
feat/ingest-keys-custom-ui

fix(web): call the key breadcrumb hook before the settings redirects

8546136
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 17, 2026 in 22s

Confidence 9/10 · No issues found

🟢 Confidence 9/10 · safe to merge
The only change since the last review moves useIngestKeyCrumbs above the retired-tab redirects, where it now runs unconditionally; no test pins the ordering.
quality 100/100 · no findings · tests partial · risk low

SettingsPage now reads the ingest-key crumbs before the retired-tab redirects, so /settings?tab=developer and its neighbours no longer render a different number of hooks. The hook ordering fix is the whole change since the last review; safe to merge.

  • useIngestKeyCrumbs runs unconditionally at the top of SettingsPage, before the legacy-tab Navigate returns

Fixed since the last review

  • ✅ F2 · useIngestKeyCrumbs runs after the legacy-tab early returns and crashes /settings?tab=developer

Production impact

Production traffic of the changed files (last 7 days)
File Calls/day Busiest operations
apps/web/src/components/settings/ingest-keys/shared.ts 1.2M POST /v1/traces 467k/day, 0.0% err
POST /v1/traces 255k/day, 0.0% err
POST /v1/metrics 186k/day, 0.0% err
What was checked
  • The redirects at settings.tsx:66-75 now all follow useIngestKeyCrumbs (settings.tsx:63), so every render calls the same hooks
  • The crumb hook is fed undefined unless tab=ingestion (settings.tsx:63), so other tabs still skip the key-list fetch

8546136 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.