Repository navigation
feat(alerts): warning and critical tiers, recovery values and N-of-M on one rule - #1509
Merged
Merged
Maple Review Bot / Maple / review
succeeded
Oct 17, 2026 in 51s
Confidence 9/10 · No issues found
🟢 Confidence 9/10 · safe to merge
The only delta since the last review is a non-blocking e2e step whose env and artifact path I verified against the e2e suite and deploy-setup.
quality 100/100 · no findings · tests covered · risk low
Adds warning/critical tiers, recovery values and N-of-M to alert rules, with the v2 API, scheduler, delivery, migrations and a new browser e2e suite. The only change since the last review is the CI step that runs that suite against a PR preview; it is safe to merge.
- Runs the browser e2e suite against each fresh PR preview after the smoke test
- Non-blocking (
continue-on-error), uploadingapps/web/e2e/.e2e/as thee2e-resultsartifact
Before merge
- Migration · Check it is safe on production data and with the code still deployed ·
packages/db/drizzle/20261015225936_alert_severity_tiers/migration.sql - Migration · Check it is safe on production data and with the code still deployed ·
packages/db/drizzle/20261017151322_merge_alert_tiers_and_digest/migration.sql - Migration · Check it is safe on production data and with the code still deployed ·
packages/domain/src/clickhouse/migrations/0041_alert_checks_level.ts - Warehouse · Deploy the schema before the code that reads it ·
packages/domain/src/tinybird/datasources.ts - Manual · Optional: add
ANTHROPIC_API_KEYto Infisicaldevto enable theagent.*e2e steps
Production impact
Production traffic of the changed files (last 7 days)
| File | Calls/day | Busiest operations |
|---|---|---|
packages/backend/src/services/errors/issue-hub.ts |
15 | IssueHub.recordIssueEvent 15/day, 0.0% err |
apps/web/src/lib/alerts/form-utils.ts |
7 | POST /v2/alerts/rules 7/day, 0.0% err |
Telemetry this change adds and removes (2)
- ➕ span name
IssueHub.escalateAlertIssue·packages/backend/src/services/errors/issue-hub.ts:377 - ➕ span name
IssueHub.raiseDetectorSeverity·packages/backend/src/services/errors/issue-hub.ts:403
What was checked
PREVIEW_SIGNIN_KEYreaches the e2e step from Infisical:deploy-setupexports it viaexport-type: env(action.yml:47), the same way the smoke step getsCLERK_SECRET_KEYinclude-hidden-files: trueis needed and correct for a dot-directory path, matchingbackup-restore-test.yml:63- Artifact path/name has no collision and the upload is guarded so a teardown or skipped e2e writes nothing
243616c · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading