Skip to content

feat(gcp): tabbed Google Cloud dashboard with project, region and workload filters - #1496

Closed
JeremyFunk wants to merge 7 commits into
feat/gcp-integration-page-plainfrom
feat/gcp-dashboard-tabs
Closed

JeremyFunk wants to merge 7 commits into
feat/gcp-integration-page-plainfrom
feat/gcp-dashboard-tabs

Merge remote-tracking branch 'origin/feat/gcp-dashboard-template' int…

e2ceedd
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review completed Oct 15, 2026 in 2m 36s

Confidence 5/10 · 2 issues to address

🟡 Confidence 5/10 · needs attention
The engine and template additions are pinned by new tests, but the unescaped $project filter and the uncapped metric-name input are still open at this head.
quality 80/100 · 2 warnings · tests partial · risk medium · 1/1 new units observable

Tabbed Google Cloud dashboard template with Project / Region / Workload query variables over a new metric variable source, plus a gcp service-map platform. Engine work is tested; the two earlier warnings still stand, and the generated lab fixture was only partly read.

  • gcpTemplate gains Project/Region/Workload query variables and one tab per service
  • New metric variable source lists attribute values from named metrics of one metricType
  • Service map classifies and legends a gcp platform
  • buildTemplatePreview stacks the root canvas and each section's first tab

Still open from earlier reviews

What was checked
  • Where-clause interpolation substitutes variable values raw (interpolate.ts:73); share links constrain the charset (share-variables.ts:64)
  • Resource-scoped metric option query reads the raw metrics table via ResourceAttributes (attribute-keys.ts:156), pinned by attribute-keys.test.ts
  • gcp is classified before the Lambda rule in both the API and the local UI (query-engine.http.ts:259, use-local-service-map.ts:111)
Observability coverage: 1 of 1 changes observable
Change Kind Observable Evidence
Dashboard variable option list from named metrics (metric-scoped attributeValues query) warehouse read yes runs through executeCHQuery with context attributeValues:metric-scoped (runtime/query-engine.ts:2338)

e2ceedd · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.