Repository navigation
fix(infra): stop alchemy forcing an update on observability destinations - #1479
Conversation
…estinations beta.83's ObservabilityDestination.diff returns "update" for any state written by older versions, to re-read destinationConf as Redacted. That reconcile lists the account's destinations, which the prd deploy token may not do, so every us prd deploy since #1448 fails with a 403 on workers-observability-{logs,traces} and the api Worker never updates. Patch out the one-time migration so unchanged destinations diff to noop again, as they did on beta.81.
Maple review🟢 Confidence 8/10 · likely safe to merge A bun patch removes alchemy beta.83's one-time
Before merge
What was checked
|
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters: 1
📒 Files selected for processing: 2
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Merged with 1 step from "Before merge" still open. If it is done, tick it on the review comment; if not, now is the time.
|
…e API (#1482) The first beta.83 prd deploy left workers-observability-{logs,traces} in state status "updating" after its 403. Alchemy resumes an interrupted update whatever the diff returns, so #1479's diff patch never applied and every prd deploy still reconciled, listed destinations, got a 403, and skipped the api Worker. reconcile now returns the stored attributes, with destinationConf wrapped as Redacted, when the last-applied url, headers and enabled flag match the desired ones. Those rows commit as "updated" without any API call and later deploys diff to noop. A real change still observes and PATCHes as before.
Every us prd deploy since #1448 (alchemy beta.83) fails on
workers-observability-logs/workers-observability-traceswithForbidden: Authentication error, so the api Worker is left on the old revision (the post-deploy check reports a partial deploy).beta.83's
ObservabilityDestination.diffreturnsupdatewhenever stored state holdsdestinationConfas a plain string (state from older versions), to re-read it asRedacted. The reconcile that follows lists the account's destinations, which the deploy token is not allowed to do. On beta.81 these resources diffed tonoop.This patches that one-time migration out of alchemy (src + lib), so unchanged destinations are
noopagain. The storeddestinationConfstays a plain string, which nothing in Maple reads.Alternative: give the prd deploy token read access to Workers Observability destinations and drop this patch.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.