Repository navigation
fix(types): export ParamEntry and ParamsIn - #31
Merged
Merged
Maple Review Bot / Maple / review
succeeded
Oct 14, 2026 in 51s
Confidence 10/10 · No issues found
🟢 Confidence 10/10 · safe to merge
Type-only re-exports; OptionalParamEntry/OptionalParams are public at src/core.ts:102 and reach both dialect entries through export * from "./core".
quality 100/100 · no findings · tests covered · risk low
Exports ParamEntry, OptionalParamEntry, OptionalParams, ParamsIn and ParamsSatisfied from core, so declaration emit for exported param queries and defineFn helpers can name them. Safe to merge.
core.tsre-exports the five param types; dialect entries pick them up viaexport * from "./core"test:packagenow compiles a declaration-emitting consumer coveringwhen,whenTrue, union-named params, joins, CTEs, subqueries, unions
Fixed since the last review
- ✅
F1 ·whenqueries still fail declaration emit:OptionalParamEntryunexported
What was checked
OptionalParamEntryandOptionalParamsare exported (src/core.ts:102), so the earlierwhen/whenTrueTS4023 is gone- No duplicate export of these names in
core.tsor the dialect barrels (src/clickhouse.ts:7,src/postgres.ts:16)
56a2893 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading