Skip to content

fix(types): export ParamEntry and ParamsIn - #31

Merged
Makisuo merged 2 commits into
mainfrom
feat/export-param-types
Oct 14, 2026
Merged

Makisuo merged 2 commits into
mainfrom
feat/export-param-types

fix(types): also export OptionalParamEntry and OptionalParams

56a2893
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 14, 2026 in 51s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge
Type-only re-exports; OptionalParamEntry/OptionalParams are public at src/core.ts:102 and reach both dialect entries through export * from "./core".
quality 100/100 · no findings · tests covered · risk low

Exports ParamEntry, OptionalParamEntry, OptionalParams, ParamsIn and ParamsSatisfied from core, so declaration emit for exported param queries and defineFn helpers can name them. Safe to merge.

  • core.ts re-exports the five param types; dialect entries pick them up via export * from "./core"
  • test:package now compiles a declaration-emitting consumer covering when, whenTrue, union-named params, joins, CTEs, subqueries, unions

Fixed since the last review

  • ✅ F1 · when queries still fail declaration emit: OptionalParamEntry unexported
What was checked
  • OptionalParamEntry and OptionalParams are exported (src/core.ts:102), so the earlier when/whenTrue TS4023 is gone
  • No duplicate export of these names in core.ts or the dialect barrels (src/clickhouse.ts:7, src/postgres.ts:16)

56a2893 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.