Skip to content

Permutations and permutable sequences - #70

Open
Malkovsky wants to merge 1 commit into
mainfrom
feature/cyclic_shift_storage
Open

Malkovsky wants to merge 1 commit into
mainfrom
feature/cyclic_shift_storage

Conversation

@Malkovsky

Copy link
Copy Markdown
Owner
  • Introduced permutations with logarithmic cyclic shifts
  • Permutable sequences as well with cyclic shifts
  • Fast algorithms for short blocks

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 21, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-21T18:52:17.045406Z ce0ef42 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Sep 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.54843% with 125 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.08%. Comparing base (4e52a07) to head (ce0ef42).

Files with missing lines Patch % Lines
include/pixie/detail/sequence/sequence_tree.h 88.26% 15 Missing and 54 partials ⚠️
include/pixie/permutations/sequence.h 92.06% 0 Missing and 10 partials ⚠️
src/tests/bit_sequence_tests.cpp 98.84% 4 Missing and 5 partials ⚠️
src/tests/permutable_sequence_tests.cpp 97.74% 3 Missing and 6 partials ⚠️
include/pixie/bits.h 75.00% 0 Missing and 6 partials ⚠️
include/pixie/detail/sequence/bit_block.h 91.30% 3 Missing and 3 partials ⚠️
include/pixie/detail/sequence/pointer_block.h 88.23% 1 Missing and 3 partials ⚠️
src/tests/packed_sequence_tests.cpp 97.96% 3 Missing and 1 partial ⚠️
include/pixie/detail/sequence/packed_value_block.h 92.68% 1 Missing and 2 partials ⚠️
include/pixie/permutations/permutation.h 94.00% 1 Missing and 2 partials ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   91.34%   92.08%   +0.74%     
==========================================
  Files          53       68      +15     
  Lines       13118    15926    +2808     
  Branches     1830     2221     +391     
==========================================
+ Hits        11983    14666    +2683     
- Misses        523      555      +32     
- Partials      612      705      +93     
Flag Coverage Δ
gcov 92.08% <95.54%> (+0.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant