Repository navigation
Leave out environment variables that render empty - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Compose service's environment variable that renders empty (an optional need unbound, a param missing) was passed as set-to-nothing. matterjs-server parses
BLUETOOTH_ADAPTERas an integer, so in the default setup — the BLE router holds every adapter, matterjs-server gets none — it crashed at start ("Invalid integer: ") and restarted forever: Matter never ran on a Hub. Empty variables are now left out (unset), as empty list items already are.Found bringing up the full stack on the MajorDom CM4 board (MG26 + ZGM230, Hub as a systemd service): with this, matterjs-server is healthy and all five integrations run. Tested: the existing unbound-OTBR test now asserts the variable is unset (failed before the fix); 399 tests, ruff, ty.