Skip to content

fix(local): read the size in a Featherless-shaped listing row's id - #2029

Merged
MODSetter merged 1 commit into
MODSetter:devfrom
jamalkamaladdin:fix/1988-featherless-size
Sep 29, 2026
Merged

MODSetter merged 1 commit into
MODSetter:devfrom
jamalkamaladdin:fix/1988-featherless-size

Conversation

@jamalkamaladdin

@jamalkamaladdin jamalkamaladdin commented Sep 29, 2026 •

Copy link
Copy Markdown

What

modules/llm/profile/fingerprint.py: from_remote reads a stated size out of a listing row's id when it has no hugging_face_id.

An empty owned_by and no slash in an id leaves vendor unset instead of an empty string.

Why

Fixes #1988

How to test

cd surfsense_local/backend
uv run pytest -m unit tests/unit/llm/profile/
uv run ruff check modules/llm/profile/fingerprint.py
cd ../.. && python scripts/check_docs.py

High-level PR Summary

This PR fixes how the system extracts model size and vendor information from API listing rows that lack a hugging_face_id field. Previously, models from providers like Featherless (which don't include HuggingFace IDs) were misclassified as frontier models regardless of their actual size. The fix enables reading size information directly from the model ID and properly handles edge cases like empty vendor names, ensuring models like qwen3-4b are correctly identified as 4B parameter models instead of being treated as frontier-tier.

⏱️ Estimated Review Time: 5-15 minutes

💡 Review Order Suggestion
Order File Path
1 surfsense_local/backend/tests/unit/llm/profile/test_fingerprint.py
2 surfsense_local/backend/modules/llm/profile/fingerprint.py
3 docs/architecture/local-models/selection.md

Need help? Join our Discord

surfsense_local/backend/modules/llm/profile/fingerprint.py: from_remote()
now checks the id for a stated size before falling back to a vendor,
so a row with no hugging_face_id classifies on size when its id states
one. An empty owned_by and no slash in the id now leaves vendor unset
instead of an empty string.

surfsense_local/backend/tests/unit/llm/profile/test_fingerprint.py: add
a Featherless-shaped row and a slashless id with no size or vendor.

docs/architecture/local-models/selection.md: update the Fingerprint
Remote bullet and delete the closed Known gaps line.
@vercel

vercel Bot commented Sep 29, 2026

Copy link
Copy Markdown

@jamalkamaladdin is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 2420a2ee-40c3-42e9-8c65-9fbf1fb0c555

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MODSetter
MODSetter merged commit 38d4bef into MODSetter:dev Sep 29, 2026
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants