Repository navigation
Add onyphe-service object for observed services and vulnerability verdicts - #550
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ONYPHE Search now exposes layered ctiscan/ctiurl documents alongside flat datascan/riskscan/vulnscan documents. Generic ip-port and x509 objects represent endpoints and certificates, but do not retain the category, application metadata, risk tags and vulnerability verdicts together as one observation.
Add
onyphe-servicewith typed endpoint, product/CPE, HTTP and response metadata, observation dates, source tags and a mandatory original JSON attachment. Multiple leaf values are retained independently; component arrays do not imply product/vendor/version pairings. CVE mentions explicitly require consulting verdict tags and do not by themselves assert vulnerability. All attributes default toto_ids=false.The companion misp-modules update (MISP/misp-modules#962) links service observations to existing ip-port, x509 and vulnerability objects. A bundled copy lets the module work before the next object/PyMISP release; MISP installations should install this template to import the results.
Reference: https://github.com/onyphe/material/tree/master/openapi (2026-10-21).
Validation: ran the repository JSON normalizer; all 453 object definitions pass the upstream schema; UUID uniqueness passes; all 323 relationship names/opposites validate; all 22 upstream unit tests pass. The module's 85 offline tests include strict PyMISP object validation.