Repository navigation
Add generic DNS resource record object with full RDATA and pivots #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,166 @@ | ||
| { | ||
| "attributes": { | ||
| "domain": { | ||
| "description": "Domain name extracted from the resource record data.", | ||
| "misp-attribute": "domain", | ||
| "multiple": true, | ||
| "to_ids": false, | ||
| "ui-priority": 1 | ||
| }, | ||
| "email": { | ||
| "description": "Email address extracted from resource record data or mail policy text.", | ||
| "misp-attribute": "email", | ||
| "multiple": true, | ||
| "to_ids": false, | ||
| "ui-priority": 1 | ||
| }, | ||
| "expire": { | ||
| "description": "SOA expiry interval in seconds.", | ||
| "disable_correlation": true, | ||
| "misp-attribute": "counter", | ||
| "to_ids": false, | ||
| "ui-priority": 0 | ||
| }, | ||
| "ip": { | ||
| "description": "IP address or network extracted from address records, SPF or service binding hints.", | ||
| "misp-attribute": "ip-dst", | ||
| "multiple": true, | ||
| "to_ids": false, | ||
| "ui-priority": 1 | ||
| }, | ||
| "minimum": { | ||
| "description": "SOA minimum negative-cache TTL in seconds.", | ||
| "disable_correlation": true, | ||
| "misp-attribute": "counter", | ||
| "to_ids": false, | ||
| "ui-priority": 0 | ||
| }, | ||
| "port": { | ||
| "description": "Service port extracted from SRV or service binding data.", | ||
| "disable_correlation": true, | ||
| "misp-attribute": "port", | ||
| "multiple": true, | ||
| "to_ids": false, | ||
| "ui-priority": 0 | ||
| }, | ||
| "priority": { | ||
| "description": "MX preference, SRV/URI priority, or service binding priority.", | ||
| "disable_correlation": true, | ||
| "misp-attribute": "counter", | ||
| "to_ids": false, | ||
| "ui-priority": 0 | ||
| }, | ||
| "queried-name": { | ||
| "description": "Absolute DNS query name, without the final root dot. May differ from rrname when aliases are followed.", | ||
| "misp-attribute": "domain", | ||
| "multiple": true, | ||
| "to_ids": false, | ||
| "ui-priority": 1 | ||
| }, | ||
| "rdata": { | ||
| "description": "Complete resource record data in DNS presentation format; preserves TXT quoting, SOA fields and unknown types.", | ||
| "misp-attribute": "text", | ||
| "to_ids": false, | ||
| "ui-priority": 1 | ||
| }, | ||
| "refresh": { | ||
| "description": "SOA secondary refresh interval in seconds.", | ||
| "disable_correlation": true, | ||
| "misp-attribute": "counter", | ||
| "to_ids": false, | ||
| "ui-priority": 0 | ||
| }, | ||
| "retry": { | ||
| "description": "SOA retry interval in seconds.", | ||
| "disable_correlation": true, | ||
| "misp-attribute": "counter", | ||
| "to_ids": false, | ||
| "ui-priority": 0 | ||
| }, | ||
| "rrclass": { | ||
| "description": "DNS resource record class, normally IN.", | ||
| "disable_correlation": true, | ||
| "misp-attribute": "text", | ||
| "to_ids": false, | ||
| "ui-priority": 0 | ||
| }, | ||
| "rrname": { | ||
| "description": "Owner name in DNS presentation form, without the final root dot except for the DNS root itself (.). Text permits root, wildcard and escaped owner names.", | ||
| "misp-attribute": "text", | ||
| "to_ids": false, | ||
| "ui-priority": 1 | ||
| }, | ||
| "rrtype": { | ||
| "description": "DNS resource record type mnemonic, or TYPE followed by its numeric code.", | ||
| "disable_correlation": true, | ||
| "misp-attribute": "text", | ||
| "to_ids": false, | ||
| "ui-priority": 1 | ||
| }, | ||
| "section": { | ||
| "description": "DNS response section where this record was observed. Authority and additional records describe their own rrname, not necessarily the queried name.", | ||
| "disable_correlation": true, | ||
| "misp-attribute": "text", | ||
| "multiple": true, | ||
| "to_ids": false, | ||
| "ui-priority": 0, | ||
| "values_list": [ | ||
| "answer", | ||
| "authority", | ||
| "additional" | ||
| ] | ||
| }, | ||
| "serial": { | ||
| "description": "SOA zone serial number.", | ||
| "disable_correlation": true, | ||
| "misp-attribute": "counter", | ||
| "to_ids": false, | ||
| "ui-priority": 0 | ||
| }, | ||
| "soa-email": { | ||
| "description": "SOA responsible mailbox converted from DNS RNAME notation to an email address.", | ||
| "misp-attribute": "dns-soa-email", | ||
| "to_ids": false, | ||
| "ui-priority": 1 | ||
| }, | ||
| "text": { | ||
| "description": "Decoded TXT/SPF character strings concatenated in order; rdata preserves original chunk boundaries.", | ||
| "misp-attribute": "text", | ||
| "multiple": true, | ||
| "to_ids": false, | ||
| "ui-priority": 0 | ||
| }, | ||
| "ttl": { | ||
| "description": "Remaining time to live in seconds as returned by the resolver.", | ||
| "disable_correlation": true, | ||
| "misp-attribute": "counter", | ||
| "to_ids": false, | ||
| "ui-priority": 0 | ||
| }, | ||
| "url": { | ||
| "description": "URL extracted from resource record data; no HTTP request is implied.", | ||
| "misp-attribute": "url", | ||
| "multiple": true, | ||
| "to_ids": false, | ||
| "ui-priority": 1 | ||
| }, | ||
| "weight": { | ||
| "description": "SRV or URI relative weight.", | ||
| "disable_correlation": true, | ||
| "misp-attribute": "counter", | ||
| "to_ids": false, | ||
| "ui-priority": 0 | ||
| } | ||
| }, | ||
| "description": "A single DNS resource record observed through active resolution, preserving its query name, owner, type, class, TTL and complete RDATA alongside extracted correlation pivots. Object first_seen and last_seen record observation time, not zone history.", | ||
| "meta-category": "network", | ||
| "name": "dns-resource-record", | ||
| "required": [ | ||
| "queried-name", | ||
| "rrname", | ||
| "rrtype", | ||
| "rdata" | ||
| ], | ||
| "uuid": "c6138676-09a5-4c3d-b73e-654df15e3242", | ||
| "version": 1 | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For root (
.), single-label, or escaped query names, this required attribute cannot be created: MISP strips terminal dots fromdomainvalues and then validates them as a dotted name with a multi-character final label (MISP validator). A root query therefore becomes an empty invalid value, while other valid DNS names such aslocalhostare also rejected, preventing this otherwise generic resource-record object from representing their responses. Usetexthere, as already done forrrname, or otherwise provide a required representation that supports the full DNS name syntax.Useful? React with 👍 / 👎.