Repository navigation
Make images optional in decoded QR-code and barcode objects - #546
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow decoded barcode and QR-code results to be shared without attaching the original image.
decoded-barcode, removebarcode-imagefromrequired, leavingdecoded-valuerequired.decoded-qrcode, replacerequiredOneOf: ["decoded-value", "qr-image"]withrequired: ["decoded-value"], making the decoded result the minimum content.Both image attributes remain available as optional attachments.
Compatibility: the QR-code template previously accepted image-only objects. With this change, both templates require a decoded value.
Validation: both updated templates pass
schema_objects.jsonvalidation andjq -S -jformatting checks. Attribute definitions and UUIDs are preserved. Full./validate_all.shwas not run locally because the workspace proxy prevented cloning the repository; GitHub Actions will run the full suite.