Repository navigation
fix(docker): correctly pass PHP_PACKAGE_VERSION in multi-stage build - #459
Merged
ostefano merged 2 commits intoOct 8, 2026
Merged
Conversation
…to fix update-alternatives
ostefano
reviewed
Oct 8, 2026
ostefano
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a multi-stage Docker build failure in
core/Dockerfilewhereupdate-alternativesfails during thephp-buildstage.Error:
update-alternatives: error: alternative /usr/bin/php for php not registered; not settingRoot Cause
Docker
ARGvariables do not automatically persist acrossFROMstages. BecausePHP_PACKAGE_VERSIONwas missing in later stages, it resolved to an empty string. This broke package resolution (installingphp-devinstead of a specific version) and caused theupdate-alternativessymlink command to fail.Changes Made
PHP_PACKAGE_VERSIONandPHP_API_VERSIONasENVfor better propagation.ARG PHP_PACKAGE_VERSION(and API version) to ensure variables expand correctly for package installation and symlinks.