Skip to content

fix: add AAD auth_property_name env support - #458

Merged
ostefano merged 1 commit into
MISP:masterfrom
0kn0t0K:fix/aad-auth-property-name
Oct 10, 2026
Merged

ostefano merged 1 commit into
MISP:masterfrom
0kn0t0K:fix/aad-auth-property-name

Conversation

@0kn0t0K

@0kn0t0K 0kn0t0K commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Summary

The Docker deployment did not expose the Entra/Azure AD auth_property_name setting even though the upstream MISP AadAuth plugin supports it.

This meant deployments could not override the default property used to match users (userPrincipalName) when their tenant expects mail instead.

Changes

  • add AAD_AUTH_PROPERTY_NAME to the runtime env template
  • pass the value through docker-compose.yml
  • write AadAuth.auth_property_name into the generated MISP config
  • document the new option in the README

Why

Upstream MISP expects:

Configure::read('AadAuth.auth_property_name') ?? 'userPrincipalName';

@ostefano
ostefano self-requested a review October 8, 2026 10:13
@0kn0t0K

0kn0t0K commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Hi, this PR adds support for AadAuth.auth_property_name in the Docker env config. The upstream MISP plugin supports both userPrincipalName and mail, but the Docker repo was not exposing that setting. This fixes Entra deployments that authenticate using the mail attribute.

@ostefano ostefano added enhancement New feature or request scheduled Will merge at the next opportunity labels Oct 9, 2026
@ostefano ostefano self-assigned this Oct 9, 2026
@ostefano
ostefano merged commit 5161bfe into MISP:master Oct 10, 2026
6 checks passed
@ostefano ostefano linked an issue Oct 10, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request scheduled Will merge at the next opportunity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

auth_property_name envar

2 participants