Repository navigation
fix: add AAD auth_property_name env support - #458
Merged
Merged
Conversation
ostefano
self-requested a review
October 8, 2026 10:13
Contributor
Author
|
Hi, this PR adds support for AadAuth.auth_property_name in the Docker env config. The upstream MISP plugin supports both userPrincipalName and mail, but the Docker repo was not exposing that setting. This fixes Entra deployments that authenticate using the mail attribute. |
ostefano
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Docker deployment did not expose the Entra/Azure AD
auth_property_namesetting even though the upstream MISPAadAuthplugin supports it.This meant deployments could not override the default property used to match users (
userPrincipalName) when their tenant expectsmailinstead.Changes
AAD_AUTH_PROPERTY_NAMEto the runtime env templatedocker-compose.ymlAadAuth.auth_property_nameinto the generated MISP configWhy
Upstream MISP expects: