fix(tauri): Fix Linux Tauri Popout Windows - #1137
Open
DaVinciLord wants to merge 2 commits into
Open
DaVinciLord wants to merge 2 commits into
DaVinciLord wants to merge 2 commits into
Conversation
Handle WebKitGTK window.open requests natively so popout windows work in the Tauri app on Linux. Add a localized error message for cases where no popout window can be created.
|
I've been using this for a few months now and it works really well! Nice to see Linux support caught up with other platforms. I noticed one minor issue though: when closing the main window while the popout is open, the popout stays open. The content does get cleared so you're left with a mostly blank window, not a huge deal but I figured I might as well mention it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1106
Handle WebKitGTK window.open requests natively so popout windows work in the Tauri app on Linux.
Add a localized error message for cases where no popout window can be created.