Repository navigation
docs: fix datadir snapshot listing references in README - #149
Closed
zekraken-bot wants to merge 1 commit into
Closed
zekraken-bot wants to merge 1 commit into
zekraken-bot wants to merge 1 commit into
Conversation
The README points readers at a `latest-reth-datadir` name on the mainnet snapshot page, but that page is a single snapshot listing and no longer has such an entry: the snapshots are grouped under `/reth/archival/datadir/` and `/reth/full/datadir/`. Also, the note saying all snapshots come from archival nodes conflicts with the presence of the full-node snapshot group.
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25. Or wait 46 minutes for your next included review. View limit details
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small documentation fix in the README Snapshots section.
latest-reth-datadir" on https://snapshots.lisk.com/mainnet. That page is a single snapshot listing and has nolatest-reth-datadirentry; the snapshots are grouped under two prefixes,/reth/archival/datadir/and/reth/full/datadir/. I replaced the stale reference with a pointer to the listing and named both groups./reth/full/datadir/group, so I updated it to say that snapshots are provided for both archival and full nodes.README-only change: no workflow, Dockerfile, dependency, or build-path changes.
I also checked that each listed snapshot has a matching
.sha256file and that the documentedsha256sum -c <checksum-file-name>verification works with them.@sameersubudhi could you take a look when you have a moment? Happy to adjust the wording if you'd prefer a different description of the two snapshot groups. Thanks!