Repository navigation
Conversation
This is my latest update. I am currently the sole core editor of Naraka (as I am also an associated member of the Naraka Pro League). This update has been made after careful reconsideration. I have removed any redundant variable names and HTML code. All retained and deleted features are deemed necessary by me. The previous "coming game" feature was not applicable and contained bugs, while the "common heroes" feature was also not practical. As for why I deleted some comments, it's because I mainly reconstructed the code from other game events, primarily from Warcraft. I used to be an editor there and I am quite familiar with it. The code was reconstructed based on that division, rather than being modified from the Naraka codebase. I sincerely hope to be applied or improved
steve020607
requested changes
Nov 2, 2026
steve020607
reviewed
Nov 2, 2026
steve020607
changed the title
steve020607
changed the title
steve020607
approved these changes
Nov 2, 2026
steve020607
left a comment
steve020607
left a comment
Collaborator
There was a problem hiding this comment.
on my POV, it's fine, but let's see what other reviewer that more good at lua says
hjpalpha
reviewed
Nov 2, 2026
|
|
||
| ---@param lpdbData table | ||
| ---@param args table | ||
| ---@param personType string |
| lpdbData.extradata['signatureHero' .. heroIndex] = CharacterNames[hero:lower()] | ||
| end | ||
|
|
||
| function CustomPlayer:adjustLPDB(lpdbData, args) |
Collaborator
There was a problem hiding this comment.
Suggested change
| function CustomPlayer:adjustLPDB(lpdbData, args) | |
| function CustomPlayer:adjustLPDB(lpdbData, args, personType) |
even if you do not use the param it gets passed from the caller
| local CURRENT_YEAR = DateExt.getYearOf() | ||
|
|
||
| -- T1 and T2 tournament champions | ||
| local CHAMPION_CONDITIONS = { |
Collaborator
There was a problem hiding this comment.
why is it called CHAMPION_CONDITIONS?
Comment on lines
+60
to
+63
| -- Uppercase first letter in status | ||
| if args.status then | ||
| args.status = mw.getContentLanguage():ucfirst(args.status) | ||
| end |
| end | ||
|
|
||
| local currentYearEarningsDisplay = | ||
| '$' .. mw.getContentLanguage():formatNum(Math.round(currentYearEarnings)) |
Collaborator
There was a problem hiding this comment.
imo use Currency.formatMoney
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my latest update. I am currently the sole core editor of Naraka (as I am also an associated member of the Naraka Pro League). This update has been made after careful reconsideration. I have removed any redundant variable names and HTML code. All retained and deleted features are deemed necessary by me. The previous "coming game" feature was not applicable and contained bugs, while the "common heroes" feature was also not practical. As for why I deleted some comments, it's because I mainly reconstructed the code from other game events, primarily from Warcraft. I used to be an editor there and I am quite familiar with it. The code was reconstructed based on that division, rather than being modified from the Naraka codebase. I sincerely hope to be applied or improved