Repository navigation
fix(PortalStatistics): missing Misc on coverageTournamentTable - #8234
Open
steve020607 wants to merge 3 commits into
Open
steve020607 wants to merge 3 commits into
steve020607 wants to merge 3 commits into
Conversation
| }) | ||
| end | ||
| for _, tierTypeValue in ipairs(args.showTierTypes) do | ||
| local _, tierTypeData = Tier.raw(nil, tierTypeValue) |
Collaborator
Author
There was a problem hiding this comment.
Cna you explain it a bit why it's not working?
Contributor
There was a problem hiding this comment.
It at least displays everything correct https://liquipedia.net/overwatch/User:IGeneral/Statistics#dev_for_misc_fix
Collaborator
Author
There was a problem hiding this comment.
yeah but it's better if it's fixed, since it can caused something like break or not
but idk what when wrong with this
Collaborator
Author
There was a problem hiding this comment.
can you check the output of the claude @ElectricalBoy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://discord.com/channels/93055209017729024/268719633366777856/1560558776698937418
The Misc row are just gone from the module
This PR fix it
Developed by Claude,
How did you test this change?
dev