Remove restated Thorlabs LCC1620 manual from device notes - #56
Merged
Conversation
The device-notes file reproduced the Thorlabs user guide chapter by chapter (specs, figure data, timing tables, mechanical drawing, certification), which a review flagged as a copyright risk. Keep only the rig wiring and driver notes written for this repo, a three-point summary of the facts the driver relies on, and a link to the official PDF. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the Copilot review finding on #52:
lcc1620_device_notes.mdrestated the full Thorlabs LCC1620 user guide chapter by chapter. This keeps only the repo-specific rig wiring and driver notes, a three-point summary of the facts the driver depends on, and a link to the official PDF. Documentation only, no code change.The other three findings from that review (duplicate calibration voltages, constructor accepting a bad DAC channel, missing interpolation tests) are not in this PR.
🤖 Generated with Claude Code