Repository navigation
feat: add geoip2/geoip2 for local MaxMind City lookups - #101
Merged
Merged
Conversation
16 of 22 tasks
vitormattos
requested changes
Sep 20, 2026
lfals
marked this pull request as draft
September 20, 2026 21:42
Add MaxMind GeoIP2 and regenerate scoped composer/ dependencies for signer IP geolocation support in LibreSign. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
lfals
force-pushed
the
feat/geoip2-dependency
branch
from
September 20, 2026 21:57
2e04147 to
beb2ea1
Compare
vitormattos
requested changes
Sep 20, 2026
Use the full version number required by the README update flow. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
lfals
marked this pull request as ready for review
September 20, 2026 23:45
vitormattos
approved these changes
Sep 21, 2026
lfals
added a commit
to lfals/libresign
that referenced
this pull request
Sep 21, 2026
Point the submodule at the merged LibreSign/3rdparty#101 tip so the geoip2 package is reachable from the official repo before merge. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
cursor Bot
pushed a commit
to lfals/libresign
that referenced
this pull request
Sep 25, 2026
Point the submodule at the merged LibreSign/3rdparty#101 tip so the geoip2 package is reachable from the official repo before merge. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
lfals
added a commit
to lfals/libresign
that referenced
this pull request
Sep 25, 2026
Point the submodule at the merged LibreSign/3rdparty#101 tip so the geoip2 package is reachable from the official repo before merge. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
lfals
added a commit
to lfals/libresign
that referenced
this pull request
Sep 25, 2026
Point the submodule at the merged LibreSign/3rdparty#101 tip so the geoip2 package is reachable from the official repo before merge. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Add
geoip2/geoip2^3.4(MaxMind GeoIP2 + transitive MaxMind DB reader / web-service-common / ca-bundle) and regenerate scopedcomposer/dependencies underOCA\Libresign\Vendor\for local MaxMind City lookups used by LibreSign signer IP geolocation.Branch rebuilt from current
mainfollowing the README update flow (composer update→ wipe →composer install --no-dev→git clean→composer dump-autoload).🧪 How to test
composer.jsonrequires"geoip2/geoip2": "^3.4".composer/geoip2/geoip2/src/Database/Reader.phpunder namespaceOCA\Libresign\Vendor\GeoIp2\Database.composer/composer/installed.jsonhas"dev": false.⚙️ API / Back‑end changes
geoip2/geoip2and regenerated PHP-Scoper output incomposer/composer openapi– N/A🚧 Tasks
3rdpartysubmodule SHA in LibreSign (e.g. #8414) to this merge commit✅ Checklist
composer install --no-devactlint-php workflow passed🤖 AI (if applicable)