Skip to content

feat: add geoip2/geoip2 for local MaxMind City lookups - #101

Merged
vitormattos merged 2 commits into
LibreSign:mainfrom
lfals:feat/geoip2-dependency
Sep 21, 2026
Merged

vitormattos merged 2 commits into
LibreSign:mainfrom
lfals:feat/geoip2-dependency

Conversation

@lfals

@lfals lfals commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

📝 Summary

Add geoip2/geoip2 ^3.4 (MaxMind GeoIP2 + transitive MaxMind DB reader / web-service-common / ca-bundle) and regenerate scoped composer/ dependencies under OCA\Libresign\Vendor\ for local MaxMind City lookups used by LibreSign signer IP geolocation.

Branch rebuilt from current main following the README update flow (composer update → wipe → composer install --no-dev → git clean → composer dump-autoload).

🧪 How to test

  1. Confirm composer.json requires "geoip2/geoip2": "^3.4".
  2. Confirm scoped classes exist, e.g. composer/geoip2/geoip2/src/Database/Reader.php under namespace OCA\Libresign\Vendor\GeoIp2\Database.
  3. Confirm composer/composer/installed.json has "dev": false.
  4. Re-run the vendor check locally (same as CI):
    rm -rf ./composer/*/ ./vendor/*/
    composer install --no-dev
    git clean -X -d -f
    composer dump-autoload
    git status --porcelain . \
      ':!composer/composer/installed.json' \
      ':!composer/composer/installed.php' \
      ':!composer/composer/package-versions-deprecated/src/PackageVersions/Versions.php'
    Expect empty output.

⚙️ API / Back‑end changes

  • Added geoip2/geoip2 and regenerated PHP-Scoper output in composer/
  • Unit and/or integration tests added – N/A for dependency-only bump; covered by Composer vendor CI
  • Capabilities updated (if applicable)
  • Documentation updated (if applicable)
  • API documentation updated with composer openapi – N/A

🚧 Tasks

  • Merge this PR
  • Bump the 3rdparty submodule SHA in LibreSign (e.g. #8414) to this merge commit

✅ Checklist

  • I have read and followed the contribution / README update steps for this repository.
  • Regenerated scoped dependencies with composer install --no-dev
  • Local vendor-check equivalent passed (PHP 8.3 + ext-gd)
  • Local act lint-php workflow passed

🤖 AI (if applicable)

  • The content of this PR was partially or fully generated using AI

@lfals
lfals requested a review from vitormattos as a code owner September 17, 2026 02:14
@lfals lfals closed this Sep 17, 2026
@lfals
lfals deleted the feat/geoip2-dependency branch September 17, 2026 02:30
@lfals
lfals restored the feat/geoip2-dependency branch September 20, 2026 19:57
@lfals lfals reopened this Sep 20, 2026

@vitormattos vitormattos left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to follow the instructions at README.
Delete locally this branch.
Recreate this branch locally from main
Follow the README steps
make a force push to override this branch with the newest.

@lfals
lfals marked this pull request as draft September 20, 2026 21:42
Add MaxMind GeoIP2 and regenerate scoped composer/ dependencies for
signer IP geolocation support in LibreSign.

Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
@lfals
lfals force-pushed the feat/geoip2-dependency branch from 2e04147 to beb2ea1 Compare September 20, 2026 21:57
Comment thread composer.json Outdated
Use the full version number required by the README update flow.

Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
@lfals
lfals marked this pull request as ready for review September 20, 2026 23:45
@vitormattos
vitormattos merged commit 240ef3b into LibreSign:main Sep 21, 2026
6 checks passed
lfals added a commit to lfals/libresign that referenced this pull request Sep 21, 2026
Point the submodule at the merged LibreSign/3rdparty#101 tip so the
geoip2 package is reachable from the official repo before merge.

Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
@lfals
lfals deleted the feat/geoip2-dependency branch September 21, 2026 23:05
cursor Bot pushed a commit to lfals/libresign that referenced this pull request Sep 25, 2026
Point the submodule at the merged LibreSign/3rdparty#101 tip so the
geoip2 package is reachable from the official repo before merge.

Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
lfals added a commit to lfals/libresign that referenced this pull request Sep 25, 2026
Point the submodule at the merged LibreSign/3rdparty#101 tip so the
geoip2 package is reachable from the official repo before merge.

Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
lfals added a commit to lfals/libresign that referenced this pull request Sep 25, 2026
Point the submodule at the merged LibreSign/3rdparty#101 tip so the
geoip2 package is reachable from the official repo before merge.

Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants