docs(skills): correct the list of components that render - #268
Closed
LeadcodeDev wants to merge 1 commit into
Closed
LeadcodeDev wants to merge 1 commit into
LeadcodeDev wants to merge 1 commit into
Conversation
53 tasks
LeadcodeDev
added this pull request to stack #276
September 22, 2026 05:51
LeadcodeDev
force-pushed
the
docs/skill-card-flex
branch
from
September 22, 2026 06:12
d7cb4e2 to
7015500
Compare
LeadcodeDev
force-pushed
the
docs/skill-card-flex
branch
from
September 22, 2026 06:14
7015500 to
952dce0
Compare
LeadcodeDev
force-pushed
the
docs/skill-card-flex
branch
from
September 22, 2026 08:36
952dce0 to
9c008f1
Compare
LeadcodeDev
force-pushed
the
docs/skill-card-flex
branch
from
September 22, 2026 08:46
9c008f1 to
8643103
Compare
LeadcodeDev
force-pushed
the
docs/skill-card-flex
branch
from
September 22, 2026 09:02
8643103 to
5114f8e
Compare
LeadcodeDev
force-pushed
the
docs/skill-card-flex
branch
from
September 22, 2026 09:07
5114f8e to
ecf9e41
Compare
The heading (line 40) and list (line 44) name `shape, image, icon, svg, video, gif, callout, chart, comparison, dot_map, gauge, heatmap, lottie, marquee, mockup, pill_nav, skeleton, sparkline, stat, stepper, tag_cloud, tooltip, treemap` as having no size source, "verified against ... `component_intrinsic` and `apply_intrinsic_overrides`". box_builder.rs:1605-1955 now gives every one of those a default size — the block's own comment cites this exact issue ("#126 / W3: the 23 components with no size source") — and box_builder.rs:2883 asserts each gets a positive box. This file is the LLM-facing generation guide shipped inside the published crate: it makes the model add redundant explicit `width`/`height` everywhere and, worse, line 48-50 tells it to suspect this list first when a component doesn't render, sending debugging down a dead path. The doc even claims `stat` in a flex row produces a blank frame, which the `Stat(_) => apply_default_size(css, 280.0, 180.0)` arm (box_builder.rs:1817-1825) was written specifically to fix.
Refs #220
LeadcodeDev
force-pushed
the
docs/skill-card-flex
branch
from
September 22, 2026 09:09
ecf9e41 to
4d0de37
Compare
Owner
Author
|
Closed and reopened as a fresh pull request: GitHub registered this one as part of a stack, and a stacked pull request cannot be merged through either the GraphQL or the REST merge endpoint. The finding itself is unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Severity Low, category coherence. Location:
crates/rustmotion/skills/rules/card-flex-layout.md:46Impact
The heading (line 40) and list (line 44) name
shape, image, icon, svg, video, gif, callout, chart, comparison, dot_map, gauge, heatmap, lottie, marquee, mockup, pill_nav, skeleton, sparkline, stat, stepper, tag_cloud, tooltip, treemapas having no size source, "verified against ...component_intrinsicandapply_intrinsic_overrides". box_builder.rs:1605-1955 now gives every one of those a default size — the block's own comment cites this exact issue ("#126 / W3: the 23 components with no size source") — and box_builder.rs:2883 asserts each gets a positive box. This file is the LLM-facing generation guide shipped inside the published crate: it makes the model add redundant explicitwidth/heighteverywhere and, worse, line 48-50 tells it to suspect this list first when a component doesn't render, sending debugging down a dead path. The doc even claimsstatin a flex row produces a blank frame, which theStat(_) => apply_default_size(css, 280.0, 180.0)arm (box_builder.rs:1817-1825) was written specifically to fix.Fix
Rewrite the section to describe the current behaviour: these components now get a documented default size and explicit
width/heightis an override, not a requirement. Keep a short note on which defaults are content-derived vs fixed..claude/skills/rustmotion/rules/symlinks to this tree, so one edit fixes both.Evidence the audit read
Part of the September 2026 audit remediation chantier. Refs #220 (RM-24).