ci: synchronize queued TUI artifact modal acceptance - #623
Merged
Merged
Conversation
LeXwDeX
marked this pull request as ready for review
September 20, 2026 15:13
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The published
graphagent-v1.0.46-dev.1artifact exposed a test synchronization defect: the queued TUI PTY test matched Q1 text while the Saving modal was still visible, then clicked Q2 at stale coordinates before the modal dismissed. The runtime completed the modal normally; the acceptance harness advanced too early.What changed
queued-message-artifact.test.tswith no runtime, TUI product, workflow, release, prompt, or queue behavior changes.Evidence
graphagent-v1.0.46-dev.1binary (b65e653287fb8389b9a2ad2dfccbf15ea701e4ac38b1e3919484af51b01e5234) passed the corrected PTY acceptance twice, each with 1 passed test and 17 strict assertions.d6db57adb8f50c4edc548dabb7338e027e789f1ecb9a2cf47fc9e8a408c4dacdand1ca675c96f8bd3814593c36722cd4b48d878c790f0d836ffc17e34a68a82d7ce.d3771a01ce3cd0d21d50eac7dd8a4282d9a5932dc87baa810021cf292bc829a8; the original failure evidence remains retained separately.PATHpinned to Bun 1.3.14, lint passed the existing ratchet at 4,850/4,850 warnings with 0 errors, and typecheck passed for 29/29 packages. No model requests were made.Checklist
Closes #622