Skip to content

ci: synchronize queued TUI artifact modal acceptance - #623

Merged
LeXwDeX merged 1 commit into
devfrom
fix/tui-queue-artifact-sync
Sep 20, 2026
Merged

LeXwDeX merged 1 commit into
devfrom
fix/tui-queue-artifact-sync

Conversation

@LeXwDeX

@LeXwDeX LeXwDeX commented Sep 20, 2026

Copy link
Copy Markdown
Owner

Why

The published graphagent-v1.0.46-dev.1 artifact exposed a test synchronization defect: the queued TUI PTY test matched Q1 text while the Saving modal was still visible, then clicked Q2 at stale coordinates before the modal dismissed. The runtime completed the modal normally; the acceptance harness advanced too early.

What changed

  • Wait for the queued edit modal to be absent after Q1 appears and before clicking Q2.
  • Keep the change test-only: one added wait in queued-message-artifact.test.ts with no runtime, TUI product, workflow, release, prompt, or queue behavior changes.

Evidence

  • The retained failure records Q1 matching at 4,408 ms while the Saving modal remained visible, the stale-coordinate Q2 click at 4,409 ms, and modal dismissal at 4,429 ms.
  • The same downloaded graphagent-v1.0.46-dev.1 binary (b65e653287fb8389b9a2ad2dfccbf15ea701e4ac38b1e3919484af51b01e5234) passed the corrected PTY acceptance twice, each with 1 passed test and 17 strict assertions.
  • Run manifests: d6db57adb8f50c4edc548dabb7338e027e789f1ecb9a2cf47fc9e8a408c4dacd and 1ca675c96f8bd3814593c36722cd4b48d878c790f0d836ffc17e34a68a82d7ce.
  • The merged artifact-acceptance summary SHA-256 is d3771a01ce3cd0d21d50eac7dd8a4282d9a5932dc87baa810021cf292bc829a8; the original failure evidence remains retained separately.
  • With the worktree clean and PATH pinned to Bun 1.3.14, lint passed the existing ratchet at 4,850/4,850 warnings with 0 errors, and typecheck passed for 29/29 packages. No model requests were made.

Checklist

  • Product and runtime code remain unchanged.
  • The same published binary passed two independent corrected PTY runs.
  • The original failure evidence remains preserved.
  • Current-head native CI passes before merge.

Closes #622

@LeXwDeX
LeXwDeX marked this pull request as ready for review September 20, 2026 15:13
@LeXwDeX
LeXwDeX merged commit 315163e into dev Sep 20, 2026
9 of 12 checks passed
@LeXwDeX
LeXwDeX deleted the fix/tui-queue-artifact-sync branch September 20, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: synchronize queued TUI artifact modal acceptance

1 participant