Repository navigation
stratum: blocks_found reward and fee from the mined coinbase - #108
Open
asilgulsar1 wants to merge 1 commit into
Open
asilgulsar1 wants to merge 1 commit into
asilgulsar1 wants to merge 1 commit into
Conversation
On a coinbasetxn template, job->value_sats is the negated coinbasetxn.fee: the sum of every output, and 0 when the server states no fee, in which case blocks_found got NULL reward and fee. Use coinbase_template_reward() (the one spendable output, the value the builder actually split), as the pplns-coinbase path already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We run simplepool in solo mode for eCash.com (ECX, BIP300/301) behind the CUSF enforcer. These came out of a review of the solo path before we rely on it.
On a
coinbasetxntemplate,job->value_satsis the negatedcoinbasetxn.fee. That is the sum of every output, and it is 0 when the server states no fee, in which caseblocks_foundgot a NULL reward and fee. This now usescoinbase_template_reward()(the one spendable output, the value the builder actually split), as the pplns-coinbase path already does.Test:
test_found_block_reward_comes_from_the_coinbase(a template with value 0 must still record 49 BTC reward and 1 BTC fee at 200 bps).Tested:
make testpasses on this branch alone, and the new test fails onmainwithout the fix. This PR is independent of the five others opened alongside it, and all six merge together cleanly. Happy to add a CHANGELOG entry if you'd like one.🤖 Generated with Claude Code