Repository navigation
store: bound what a reject flood can write, and never drop a found block - #107
Open
asilgulsar1 wants to merge 1 commit into
Open
asilgulsar1 wants to merge 1 commit into
asilgulsar1 wants to merge 1 commit into
Conversation
A reject costs the sender no work: authorize with any valid address, then submit bogus job ids at up to max_submits_per_sec per connection. Each wrote a rejects row (nothing deletes them), and the flood filled the event ring that block events share, so store_record_block could fail and a found block's blocks_found row was lost. - rejects_max_per_sec (default 0 = no limit): reject rows written per second, pool-wide. - Rejects stop at three quarters of the ring, leaving room for shares and blocks. - store_record_block waits (up to 30 s) for room instead of dropping the block's row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We run simplepool in solo mode for eCash.com (ECX, BIP300/301) behind the CUSF enforcer. These came out of a review of the solo path before we rely on it.
A reject costs the sender no work: authorize with any valid address, then submit bogus job ids at up to
max_submits_per_secper connection. Each one wrote arejectsrow, and nothing deletes them. The flood also filled the event ring that block events share, sostore_record_blockcould fail and a found block'sblocks_foundrow was lost.rejects_max_per_sec(default 0 = no limit) caps reject rows written per second, pool-wide.store_record_blockwaits up to 30 s for room instead of dropping the block's row.Test:
test_rejects_rate_limited.Tested:
make testpasses on this branch alone, and the new test fails onmainwithout the fix. This PR is independent of the five others opened alongside it, and all six merge together cleanly. Happy to add a CHANGELOG entry if you'd like one.🤖 Generated with Claude Code