Repository navigation
stratum: max_conns_per_ip, and a deadline from connect for unauthorized peers - #106
Open
asilgulsar1 wants to merge 1 commit into
Open
asilgulsar1 wants to merge 1 commit into
asilgulsar1 wants to merge 1 commit into
Conversation
…ed peers max_conns is global, so one host could take every slot. And an unauthorized connection's idle budget was measured from its last byte and only checked on the SO_RCVTIMEO wake, so a peer sending a blank line more often than that wake was never checked at all and held its slot for ever without a username. - max_conns_per_ip (default 0 = no limit) closes one host's extra connections at accept. - Until it authorizes, a connection gets idle_timeout_sec from connect, checked whenever bytes arrive as well as on the wake. Authorized connections are unchanged: blank-line keepalives still keep them open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We run simplepool in solo mode for eCash.com (ECX, BIP300/301) behind the CUSF enforcer. These came out of a review of the solo path before we rely on it.
max_connsis global, so one host could take every slot. An unauthorized connection's idle budget was measured from its last byte, and checked only on the SO_RCVTIMEO wake. A peer sending a blank line more often than that wake was never checked, and held its slot indefinitely without ever giving a username.max_conns_per_ip(default 0 = no limit) closes one host's extra connections at accept.idle_timeout_secfrom connect, checked whenever bytes arrive as well as on the wake. Authorized connections are unchanged: blank-line keepalives still keep them open.Tests:
test_max_conns_per_ip,test_unauthorized_deadline_runs_from_connect, andtest_authorized_keepalive_is_not_reaped, all over real sockets.Tested:
make testpasses on this branch alone, and the new test fails onmainwithout the fix. This PR is independent of the five others opened alongside it, and all six merge together cleanly. Happy to add a CHANGELOG entry if you'd like one.🤖 Generated with Claude Code