Repository navigation
stratum: a second mining.authorize pays the new address at once - #105
Open
asilgulsar1 wants to merge 1 commit into
Open
asilgulsar1 wants to merge 1 commit into
asilgulsar1 wants to merge 1 commit into
Conversation
handle_authorize replaced payout_address but kept cb_for_job_id, so the cached coinbase for the current job, which pays the previous address, was handed out again (and used to validate submits) until the next job. Shares and the blocks_found finder were recorded under the new address meanwhile. The address is now switched under cb_lock and the cache dropped with it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We run simplepool in solo mode for eCash.com (ECX, BIP300/301) behind the CUSF enforcer. These came out of a review of the solo path before we rely on it.
handle_authorizereplacedpayout_addressbut keptcb_for_job_id. Until the next job, the cached coinbase for the current job, which pays the previous address, was handed out again and used to validate submits. Meanwhile shares and theblocks_foundfinder were recorded under the new address. This matters for proxies that authorize several users on one socket. The address is now switched undercb_lock, and the cache is dropped at the same time.Test:
test_reauthorize_pays_new_address(coinb2 must change after the second authorize).Tested:
make testpasses on this branch alone, and the new test fails onmainwithout the fix. This PR is independent of the five others opened alongside it, and all six merge together cleanly. Happy to add a CHANGELOG entry if you'd like one.🤖 Generated with Claude Code