Repository navigation
Do not install hass-mcp's test launcher over the system test - #185
Merged
Merged
Conversation
Every hass-mcp wheel declares a `test = pytest:main` console script. pip put it in /usr/local/bin, ahead of /usr/bin on PATH, so any program that ran `test` by name got a Python traceback instead of the system command. The image build now removes that launcher (and fails if a file of that name is ever something else), and the image checks assert that nothing in /usr/local shadows a system command and that `test` run by name is the system one.
The fix ships with the next minor release instead of a patch of its own, so the add-on version stays at 1.62.6 until that release sets it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every published hass-mcp wheel (0.1.0 through 0.6.1) declares a
test = pytest:mainconsole script. pip installs it as/usr/local/bin/test, which comes before/usr/binon the path, so any program that runstestby name (env test,xargs test,find -exec test, a process spawn) got a Python traceback instead of the system command. pytest is not a dependency of hass-mcp, so the launcher cannot work either. Shell scripts using thetestor[builtin were not affected./usr/local/binor/usr/local/sbinhides a system command of the same name.