Repository navigation
DockerContextTests: resolve the csproj's backslash paths off Windows - #137
Merged
Merged
Conversation
MasterServer.csproj names its linked game files as ..\..\CSVM\src\..., and on Linux and macOS a backslash is not a path separator, so Path.Combine made each one a single file name inside server/MasterServer. The server/ filter then dropped every entry and Assert.NotEmpty failed. This is why the Checks workflow has been red on ubuntu-latest and macos-latest since 816308b added the test, while windows-latest passed. The Include value now has its separators normalised before it is resolved, which Windows accepts unchanged. Not run locally: this session has no dotnet SDK. The failure and the reason for it come from the CI log of run 37158829719. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015fQuGQzjRoNeTijieAfwYv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MasterServer.csproj names its linked game files as ....\CSVM\src...,
and on Linux and macOS a backslash is not a path separator, so
Path.Combine made each one a single file name inside server/MasterServer.
The server/ filter then dropped every entry and Assert.NotEmpty failed.
This is why the Checks workflow has been red on ubuntu-latest and
macos-latest since 816308b added the test, while windows-latest passed.
The Include value now has its separators normalised before it is
resolved, which Windows accepts unchanged.
Not run locally: this session has no dotnet SDK. The failure and the
reason for it come from the CI log of run 37158829719.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_015fQuGQzjRoNeTijieAfwYv