Weight Entry Optimization - #1034
Merged
LeviCameron1 merged 2 commits intoSep 10, 2026
Merged
Conversation
guyinco6nito
approved these changes
Sep 10, 2026
guyinco6nito
left a comment
guyinco6nito
left a comment
Collaborator
There was a problem hiding this comment.
I don't see any problems, approved!
-Dan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Based off of Josh's PR for 26.7 this extends it a little bit more adding a timeout on requests to 500ms. It looks like the ID field was a big problem since it was making a call to the demographics to verify the ID was correct for each keystroke. This further optimization waits for the user to stop typing before making that call.
The feeding form doesn't seem to have the same problem with the ID field as the weights form so I didn't make any changes to it.
Related Pull Requests
#1033
Changes