JUnit runner page improvements - #8040
Draft
labkey-tchad wants to merge 8 commits into
Draft
Conversation
RunAction, Run2Action, and Run3Action accepted GET despite running tests, which can be expensive or side-effecting; add @MethodsAllowed(POST) and switch runner.jsp's buttons/links to POST accordingly. GoAction already required POST via MutatingApiAction.
labkey-adam
reviewed
Sep 10, 2026
labkey-adam
left a comment
Contributor
There was a problem hiding this comment.
With this, we can probably adjust the mutating SQL detection, which currently ignores junit actions.
Member
Author
This was a bit trickier that expected. The mock ViewContexts used by some tests were tripping up the mutating SQL check. I had to tweak |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
For the most part, one is able to run individual server-side JUnit tests from

junit-begin.view. This is not the case for parameterized test classes.A minor change to how the page iterates through tests makes it function correctly for these tests.

Separately, the actions that actually run tests accepted GET requests, so a test run (some of which are expensive or have side effects) could be triggered by simply visiting a link.
Related Pull Requests
Changes