Don't defer any index creations during materialization - #8023
Open
labkey-jeckels wants to merge 3 commits into
Open
Don't defer any index creations during materialization#8023labkey-jeckels wants to merge 3 commits into
labkey-jeckels wants to merge 3 commits into
Conversation
labkey-nicka
approved these changes
Sep 7, 2026
| .addIndex("CREATE INDEX idx_${NAME}_root ON temp.${NAME} (rootmaterialrowid)") | ||
| // Deferred despite being UNIQUE. Source data guarantees uniqueness, and this is very expensive to build | ||
| .addDeferredIndex("CREATE UNIQUE INDEX uq_${NAME}_lsid ON temp.${NAME} (lsid)"); | ||
| .addIndex("CREATE UNIQUE INDEX uq_${NAME}_lsid ON temp.${NAME} (lsid)"); |
Contributor
There was a problem hiding this comment.
The comment for this line is now incorrect.
XingY
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
TeamCity has seen intermittent failures on the optimization work, seemingly related to samples being inserted but not showing up (or perhaps just not yet) in the materialized table.
The deferred index creation may be a contributing factor.
Changes
Tasks