[bot] Merge 26.9 to develop - #756
Merged
Merged
Conversation
…ed birth/arrival times (#751) ## Rationale Three NIRC updates: the death notification now fires for a death recorded alongside its necropsy, the Submit For Review dialog no longer shows a duplicate Assign To field when reopened, and birth and arrival entry now keeps the time of day. The notification and the accompanying procedure-order update were keyed off the 'Request: Pending' state. A death entered on the same form as its necropsy is submitted straight to 'Review Required' or 'Completed' and never passes through that state, so neither ran for it. The Submit For Review dialog claimed a page-wide element name for its Assign To field and only hid itself when cancelled, so a second open rendered the previous dialog's field next to the new one. Cancelling to correct a value and reopening is routine in the combined death-and-necropsy flow, which is where it showed up. Times were lost twice over: neither date column carried a format with a time component, so both forms presented a date-only editor, and the birth trigger separately discarded the time server-side, which carried through to the records derived from the birth date. ## Changes - The deaths trigger keys the notification off the move out of draft instead of off one specific target state, so it fires once per record no matter which submit button created it. - The procedure-order update moves with the notification, so it also runs for a death recorded alongside its necropsy. - The Submit For Review dialog no longer claims a page-wide element name and now discards itself when cancelled, so reopening it renders a single Assign To field. - The birth and arrival date columns declare a date-and-time display format, so entry offers a time-of-day editor and the stored time is visible. - The birth trigger no longer discards the time from the birth date, so it survives onto the birth record and everything derived from it.
cnathe
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated automatically.
Merging changes from: bd19764
Approve all matching PRs simultaneously.
Approval will trigger automatic merge.
Verify all PRs before approving: https://internal.labkey.com/Scrumtime/Backlog/harvest-gitOpenPullRequests.view?branch=fb_bot_merge_26.9