SignalDataImportTask fix to support WebDAV URL that has a context path - #1065
Merged
Merged
Conversation
- found by SignalDataFileWatcherTest on TeamCity running with contextPath = /labkey
labkey-klum
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Found by SignalDataFileWatcherTest on TeamCity running with contextPath = /labkey. The change makes the WebDAV lookup of the just-copied data file work when the server runs at a non-root context path. WebdavService.lookup() expects resolver paths without a contextPath. Swapping to lookupHref() applies the context-path substring (WebdavService.java:128-136) so resource resolves, the ExpData gets created, and the row's DataFile value is rewritten to the local copy.
Related Pull Requests
Changes