Repository navigation
Pin Microsoft.Windows.Compatibility to the patched 10.0.13 for the wa… - #17
Merged
Merged
Conversation
…sm head Uno.Sdk 6.5.36 pins Microsoft.Windows.Compatibility to 10.0.7 for the browserwasm head only, through its packages.json group WindowsCompatibility and Uno.Implicit.Packages.ProjectSystem.Wasm.targets. That carries System.Security.Cryptography.Pkcs 10.0.7, which GHSA-2fmv-rv2c-59x7 flags as moderate, so NuGet raises NU1902 and TreatWarningsAsErrors turns it into a build error. Restore covers every target framework regardless of the -f flag, so it broke builds of all heads and not only wasm. 10.0.13 is the first patched 10.0.x release. Setting it through the SDK per-group override property WindowsCompatibilityVersion avoids both a direct reference to a package the app never calls and enabling transitive pinning across central package management. Drop the line once the Uno.Sdk pinned in global.json ships 10.0.13 or newer. Verified: Pkcs now resolves to 10.0.13 and all four buildable heads build with zero errors without any NU1902 suppression. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit 2d46c19)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…sm head
Uno.Sdk 6.5.36 pins Microsoft.Windows.Compatibility to 10.0.7 for the browserwasm head only, through its packages.json group WindowsCompatibility and Uno.Implicit.Packages.ProjectSystem.Wasm.targets. That carries System.Security.Cryptography.Pkcs 10.0.7, which GHSA-2fmv-rv2c-59x7 flags as moderate, so NuGet raises NU1902 and TreatWarningsAsErrors turns it into a build error. Restore covers every target framework regardless of the -f flag, so it broke builds of all heads and not only wasm.
10.0.13 is the first patched 10.0.x release. Setting it through the SDK per-group override property WindowsCompatibilityVersion avoids both a direct reference to a package the app never calls and enabling transitive pinning across central package management. Drop the line once the Uno.Sdk pinned in global.json ships 10.0.13 or newer.
Verified: Pkcs now resolves to 10.0.13 and all four buildable heads build with zero errors without any NU1902 suppression.
(cherry picked from commit 2d46c19)