Repository navigation
fix + tests: AF3 fold without ranked samples; cover the scenarios the suites missed - #663
Merged
Merged
Conversation
…complete write_fold_outputs warned and returned when ranking_scores.csv had no rows, and postprocess went on to mark the fold complete, so --allow_resume then skipped a fold that had no model. It now raises: the job is reported failed, the fold record stays incomplete, and a resumed run predicts the fold again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
From a coverage run of the code changed since 2.10.0, a test for each uncovered case that a run can actually reach: - AF3 outputs: a seed is still written when its ModelCIF metadata cannot be added; metadata records are kept once (homodimers, copied sidecars) and an unreadable sidecar is only a warning. - AF3 runner: seeds are handed over one by one as predicted (what seed-level resume relies on); missing weights stop the fold before anything is written; a kernel record that is not a JSON object is replaced; the model config sets only the fields its AF3 release has. - AF3 inputs: a JSON input read from its .json.xz copy, and a missing one; RNA and DNA JSON chains sliced to regions; regions outside a chain or on a ligand rejected; RNA, DNA and ligand chains renamed on an ID clash; an unreadable metadata sidecar leaves the description alone; duplicate-residue normalisation skipped when the sequence does not match; template sequences shorter than the query; job names of fold inputs and of nothing. - AF3 debug: no translation summary without a translation; only rows with a species pair; the final MSA is skipped without alignments and never fails the prediction. - Storage: no best sample without a readable ranking; a slim pass on a missing or already slimmed directory. - AF2: a JSON file truncated by an older version is ignored on resume. Changed-line coverage across both images goes from 93% to 96.4%; what is left is the model forward pass (run by the GPU suites) and defensive fallbacks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…/coverage-since-2.10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #662. I measured coverage of everything changed since 2.10.0 and added a test for each uncovered case a run can actually reach. That surfaced one bug, fixed here.
The bug
write_fold_outputswarned and returned whenranking_scores.csvhad no rows, andpostprocesswent on to mark the fold complete. A later--allow_resumerun then skipped a fold that had no model. It now raises: the job is reported failed, the fold record stays incomplete, and a resumed run predicts the fold again. Its test fails on the old code (DID NOT RAISE).The tests
.json.xzcopy, as the published database ships them, and a missing one;Coverage of the code changed since 2.10.0
Measured as branch coverage over the unit and integration suites in both release images, combined: 93% → 96.4% of 1,268 changed statements. What's left:
ModelRunner, which only the GPU suites run, and all of them passed this cycle;exceptfallbacks and unreachable type guards.AlphaLink is omitted by
.coveragerc(torch). Its change in #661 was signature-only, andtest_inference_flagscovers it.Verification
main.🤖 Generated with Claude Code