Skip to content

fix(workspace): make Gists read-only and add device reset recovery - #9

Merged
KnowSky404 merged 4 commits into
mainfrom
fix/workspace-reset
Oct 31, 2026
Merged

KnowSky404 merged 4 commits into
mainfrom
fix/workspace-reset

Conversation

@KnowSky404

@KnowSky404 KnowSky404 commented Oct 31, 2026 •

Copy link
Copy Markdown
Owner

Problem and resulting behavior

Gists exposed destructive file actions, and deleting the original Gist left a bound browser unable to initialize again after Disconnect.

Make Gists read-only while retaining refresh, file links, copy, classification, and warnings. Add a confirmed Settings reset that atomically clears the current binding, cached business data, and complete current queue, retains historical recovery evidence, and returns to a separate Connect step. Reset never writes to GitHub or uploads the abandoned cache. Active delivery and concurrent reset changes are rejected; persisted CAS, fencing, and peer invalidation prevent stale reads or dispatchers from restoring the binding. Normal same-Gist initialization contention retries one fresh cloud read.

Task and verification evidence

  • Worktree / branch: /root/Clouds/SubMan-workspace-reset / fix/workspace-reset.
  • Base SHA: cdaf7487b85727915ecf2afc219cbc40b5fcbd64.
  • Tested head SHA: f526632a665390d748bec1b1e663e6d341241490.
  • Atomic commits: device reset 63aa94f, read-only Gists 53e1dd5, peer test teardown d0339c3, concurrent initialization f526632.
  • Bun 1.3.14 local checks: 712 unit tests, type/Svelte checks (zero errors or warnings), reproducible Worker types, lint, build, 37-page bilingual documentation check, and diff checks passed.
  • Final local browser suite: 72/72 passed, CI=1, retries disabled, against an isolated local Worker. The concurrent-tab regression also passed five fresh-worker invocations. GitHub calls were mocked; browser/DO state, ports, artifacts, and logs were isolated.
  • Current-head CI verify passed, including sing-box 1.14 validation, Cloudflare integration, deployment-bundle dry run, and the complete browser suite.
  • CI's mobile navigation case passed after a configured retry; the final local 72-case run passed with retries disabled.
  • English desktop (1280x900) and Chinese mobile (390x844) reset confirmation/outcome screenshots were inspected locally. Rendering, console health, copy/refresh, confirmation/cancellation, empty initialization, active-lease rejection, storage failures, and cross-tab reset were verified. Generated artifacts remain outside source.
  • The first CI run exposed a real concurrent-startup CAS mismatch; a deterministic regression was added before the bounded retry fix. Some local long-running ProxyWorker sessions also disconnected; the final complete suite passed on the exact head above.
  • Public API, Workspace schema, coordinator writer, token storage policy, and Cloudflare bindings are unchanged. No real Gist was accessed or mutated. Production deployment is outside this PR action.

Review gate

  • Current-head Codex Code Review completed; actual author and full SHA verified.
  • Current-head enabled Security Review completed; actual author and full SHA verified.
  • Per-item completion evidence recorded below.
  • No valid blocking findings or unresolved inline review threads remain.
  • Current-head CI passed.

Actual review author: chatgpt-codex-connector[bot]. Both items in the Codex Review Summary are completed for f526632a665390d748bec1b1e663e6d341241490.

  • Code Review completed 2026-10-31T07:36:38.699228Z, findings/unresolved flags false; review receipt.
  • Security Review completed 2026-10-31T07:37:45.022432Z; its independent receipt explicitly reports no security issues. Security hidden findings flags are null and were not interpreted as false.
  • Formal reviews, inline findings, and unresolved review threads were checked after completion; all were empty.
  • Actual repository rulesets/effective main rules are empty and main is unprotected. Rebase merge is enabled. Project-required review and CI gates were enforced independently of server branch protection.

Merge and completion

User authorized push, PR creation, and merge. PR was rebase-merged at 2026-10-31T07:40:07Z from the verified original head f526632a665390d748bec1b1e663e6d341241490 into merge commit dcd6e75c244769a8c9d74299b46751957f1f835e.

Fetched origin/main, proved it contains the merge SHA, verified exact final-tree equality, and checked all four original/rebased patches with git range-diff (all equal). The original clean /root/Clouds/SubMan checkout was fast-forwarded to that SHA. No conflict or integration content changes required new tests.

The automatically triggered main CI run also completed successfully for the merged SHA dcd6e75c244769a8c9d74299b46751957f1f835e.

Removed the clean PR worktree and local fix/workspace-reset branch after proving integration. The remote task branch was conditionally deleted with an explicit lease pinned to the verified PR head. External validation evidence and screenshots remain retained.

The older source-only /root/Clouds/SubMan-gists-readonly worktree and fix/gists-readonly branch remain protected by the exact-head cleanup rule: their unchanged head is 6329408, while this PR's head was f526632. Its entire change is included through 53e1dd5/40a304d; the separate source was retained rather than deleting a branch that does not satisfy that cleanup prerequisite. Production was not deployed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T07:36:38.699228Z f526632 Manual request
🔒 Security Review ✅ Completed 2026-10-31T07:37:45.022432Z f526632 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@KnowSky404

Copy link
Copy Markdown
Owner Author

@codex review

@KnowSky404

Copy link
Copy Markdown
Owner Author

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: f526632a66

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: f526632a66

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@KnowSky404
KnowSky404 merged commit dcd6e75 into main Oct 31, 2026
1 check passed
@KnowSky404
KnowSky404 deleted the fix/workspace-reset branch October 31, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant