Skip to content

fix(ui): keep cloud operations in foreground loading - #10

Merged
KnowSky404 merged 2 commits into
mainfrom
fix/cloud-operation-loading
Nov 1, 2026
Merged

KnowSky404 merged 2 commits into
mainfrom
fix/cloud-operation-loading

Conversation

@KnowSky404

@KnowSky404 KnowSky404 commented Nov 1, 2026 •

Copy link
Copy Markdown
Owner

Problem and resulting behavior

Saving or publishing showed only local button feedback, allowing users to edit drafts, dismiss editors, or navigate while a cloud operation was still running. Saves, publication generation, and Gist refresh now show a foreground loading dialog and block background interaction/navigation until the awaited result settles. Explicit confirmation dialogs remain usable. Only confirmed remote commits finalize drafts or report publication success; pending/retry/repair results retain the existing recovery behavior.

Publication captures its profile, target, and filename before generation. Export drafts initialize before unsaved-change calculations. Browser tests wait for Gist loading and dialog teardown before focusing file actions and track navigation scroll state instead of a changing button label. The public API, persistence journal, revision checks, and coordinator write boundary are unchanged.

Task and verification evidence

  • Worktree / branch: /root/Clouds/SubMan-cloud-operation-loading / fix/cloud-operation-loading.
  • Base SHA: dcd6e75c244769a8c9d74299b46751957f1f835e.
  • Current tested/reviewed head: 6daed4ab999a572ae663b3ebdbcb435dcd9d818e.
  • CI run 41284862489, attempt 1, passed for this exact head. verify job completed at 2026-11-01T07:30:47Z.
  • CI: 715 unit tests, 8 Cloudflare Worker/DO integration tests, 37-page bilingual documentation check, sing-box 1.14 validation, Svelte/types, lint, build, and Cloudflare deployment dry-run all pass.
  • CI browser result: 73 passed, 1 flaky, 0 failed. The resource-save draft-retention case passed on retry 1 after an initial missing Raw URI field assertion. All other browser cases passed on their first attempt.
  • Local Bun 1.3.14: 9 focused Vite browser tests pass; 7 critical Worker browser scenarios pass; the Gist tooltip and mobile-navigation cases each pass 3 consecutive Worker runs. After the CI flake, the resource-save case passed 15 consecutive Worker runs with one browser worker. This did not reproduce the CI failure and does not establish its cause.
  • UI evidence covers desktop English (1280x900), mobile Chinese (390x844), held cloud responses, inert drafts, Escape/backdrop resistance, navigation cancellation, confirmation focus handoffs, delayed success/live URLs, and failure/pending draft retention.
  • Screenshots were captured locally outside the repository; not uploaded.
  • Limitations: the CI resource-save flake remains recorded. No failure artifact was uploaded for the successful CI job, so its precise cause is unverified. Provider calls use fixtures; no real Gist access or production deployment is part of validation.

Review gate

  • Codex Code Review completed for the current head; actual author and reviewed SHA verified.
  • Security Review completed for the current head with an explicit receipt/report; repository review configuration checked.
  • Review SHA, completion times, and evidence links recorded.
  • No valid blocking review findings remain.
  • CI passed for the current head; all head updates were reviewed again.

Both receipts are from chatgpt-codex-connector[bot] and name 6daed4ab99, matching the full current head.

  • Code Review completed at 2026-11-01T07:29:28.441487Z; receipt reports no major issues.
  • Security Review completed at 2026-11-01T07:32:11.577635Z; receipt explicitly reports no security issues and links its report.
  • Codex Review Summary has both per-review rows on the current full head. Review submissions, inline comments, and review threads were also checked; none contain findings.
  • Repository rulesets are empty and main reports protected: false. Observed Code and Security Review configuration is active; the AGENTS.md gates are applied regardless of branch protection.

Merge and completion

  • Rebase merge and default task cleanup were authorized. PR #10 is MERGED at 2026-11-01T07:39:11Z.
  • Original reviewed head: 6daed4ab999a572ae663b3ebdbcb435dcd9d818e.
  • Final merge SHA: 243db4cc4272e7e4772355fcc7f8e06a84976259.
  • Fetched origin/main contains the merge SHA. git range-diff marks both original/rebased commits equivalent (10ebb98 = 36e20ba, 6daed4a = 243db4c); the reviewed head and merged head share tree 3265069115f1be572d6c603f9299290f0e313da5, and their content diff is empty. No conflict resolution changed content.
  • Original checkout /root/Clouds/SubMan was clean on main and synchronized with git merge --ff-only origin/main; it now points to the merge SHA and is clean.
  • Removed only this task's worktree and local branch. Deleted the remote task branch using an explicit lease pinned to the original reviewed head and verified it is absent. The existing SubMan-gists-readonly worktree/branch is preserved.
  • No temporary task server remains. Validation logs/screenshots remain outside the repository; integration metadata, range-diff evidence, and local Worker state are retained in /tmp/subman-pr10-completion. No private task configuration was found.
  • Post-merge main CI 41285646363 passed on the exact merge SHA at 2026-11-01T07:41:59Z: 715 unit tests and 74 browser tests passed with no flaky cases or retries; documentation, sing-box, types, lint, build, Cloudflare integration, and deployment dry-run also passed. No completion blockers remain.
  • Production was not deployed; merge and cleanup do not deploy production.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T07:29:28.441487Z 6daed4a Manual request
🔒 Security Review ✅ Completed 2026-11-01T07:32:11.577635Z 6daed4a Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

@codex review

Please complete Code Review for current head 10ebb98310703434eb3115665845dcad15942290. Security Review is already running. Check foreground loading, modal/confirmation focus handoffs, draft retention, and remote-confirmation gating.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 10ebb98310

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

@codex review

Please review current head 6daed4ab999a572ae663b3ebdbcb435dcd9d818e. The follow-up adjusts existing browser tests to wait for foreground Gist loading/teardown before focusing file actions and to wait for navigation scroll state. Both affected tests passed three consecutive runs against the local Worker.

Copy link
Copy Markdown
Owner Author

@codex security review

Please complete Security Review for current head 6daed4ab999a572ae663b3ebdbcb435dcd9d818e and record the reviewed commit and result in a security review receipt/report so the repository's review gate can be verified.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 6daed4ab99

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: 6daed4ab99

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@KnowSky404
KnowSky404 merged commit 243db4c into main Nov 1, 2026
1 check passed
@KnowSky404
KnowSky404 deleted the fix/cloud-operation-loading branch November 1, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant