Repository navigation
J1 (nix): make_secret actual Core join (resolvers bind InstallerCustody + private admission) [DRAFT] - #192
Merged
amad-malik merged 3 commits intoOct 19, 2026
Conversation
…eal InstallerCustody (12 tests, 19 assertion failures, 0 errors); two closed-test spots made Core-presence independent Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…e's InstallerCustody and private admission (receiver follows S4); 14 join tests over the real owner GREEN on 3.14.0 and 3.13.7 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…tered test_make_secret_effect.py (no suites-file change needed); 19 tests OK on 3.14.0 and 3.13.7 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT, source+test, on Finn's qualified head bc2f260 (the base branch head), so the diff is the J1 join alone: make_secret.py resolvers, test_make_secret_core_join.py (14 tests over Core's real InstallerCustody with Core's own adapter doubles), two closed-test spots made independent of whether Core is importable. The fixed S4 receiver is not in this tree so _receiver still resolves to None (production refuses bootstrap_receiver_unbound). Not merged by the author; Kai alone merges.
🤖 Generated with Claude Code