Repository navigation
feat: pass through zero data retention opt-in (CMD_ZDR) - #8
Merged
Merged
Conversation
Command Code exposes ZDR as x-cmd-zdr: 1, the same opt-in its CLI reads from CMD_ZDR=1. Mirror it for plugin users and strip any caller-supplied header when the opt-in is absent, so a session that never asked for ZDR cannot emit the flag by accident. Applied on the strict Command Code host only, never on a lookalike that merely shares the request path.
This was referenced Oct 31, 2026
JoshRob297
marked this pull request as ready for review
October 31, 2026 18:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Command Code exposes zero data retention as the request header
x-cmd-zdr: 1, the same opt-in its CLI reads fromCMD_ZDR=1. The plugin did not forward it, so plugin users could not ask for ZDR even though the CLI can.Change
src/hooks/zdr.ts:isZdrEnabled()(strict=== "1") andapplyZdrHeader().CMD_ZDR=1-> every request to the strict Command Code host carriesx-cmd-zdr: 1.x-cmd-zdr(any casing) is stripped, so a session that never asked for ZDR cannot emit the flag by accident./provider/v1/...in its path is never touched.Verify
bun test: 94 pass, 3 skip, 0 fail (newtests/zdr.test.tscovers set, strip, casing, no-lookalike, and the plugin hook path).bunx tsc --noEmit: clean.Remote verification pending
The ZDR header is accepted by the Provider API per the Command Code docs (
CMD_ZDR=1); live verification with the current key is pending merge.