Repository navigation
Conversation
|
Claude review: skipped (draft). It will run once the PR is marked ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The work Mac's VM–Mac bridge currently needs a manually started helper and stops when its SSH transport disconnects. Enable
fleet.vmMacBridgeforworkso a Home Manager login agent opens the approval helper in Terminal at graphical login, reconnects to the existingdevspaceSSH alias, and fetches the latest upstream helper before each start or reconnect.Every command retains Mac-local approval through notification actions or full review in the terminal. The local lock prevents a second helper from starting; Ctrl-C stops it. Requests keep their async polling, approval expiry, and separate execution timeout.
The module builds pinned terminal-notifier 3.1.0, then Home Manager installs and signs the dedicated app in
~/Applicationsbefore starting the login agent. Its bundle ID matches the existing bridge app, giving it its own macOS notification settings. Notification permission and Alerts/Banners remain one-time macOS choices.The launcher tracks
jgoon/vm-mac-bridge'smainbranch in an app-owned checkout on the Mac. Bridge updates take effect on startup/reconnect without a Nix rebuild; a running helper picks them up on its next restart or reconnect. The terminal reports the revision it starts. Git operations have a 60-second timeout, preserve local edits, and retry failed updates without starting stale cached code.Runtime Git access uses the Mac user's existing Enterprise GitHub authentication. Nix builds need the local launcher and public notifier source. The VM's compatible transport script and the Mac's working
devspaceSSH alias remain prerequisites. Usage, migration, and update behavior are documented in.config/nix.Project decisions, deployment state, and live bridge validation are recorded in the project handoff.
Validation:
checks.x86_64-linux.vm-mac-bridgeNix build passes.Draft pending a native macOS build and validation of Enterprise GitHub access, Terminal startup, codesigning, and notification approval. No machine configuration has been applied. After validation/merge, stop the old manual helper and apply on the work Mac with
make herefrom~/.config/nix.