Conversation
Still need to make a couple shared interfaces to improve quality, but this should be functional at least
This is where Spigot deprecated the nonnull key for enchantments, but enchantments do actually have to be registered to the server to function.
Bunch of gross generics and more constructor parameters, but what can you do? I guess static abuse would work too, but that feels even worse.
Paper doesn't really need one since getting a block's state without snapshotting is a lot less expensive. No need to devote memory to every block type a player right clicks.
Owner
Author
|
Okay, I've tested on Spigot and Paper 26.3 and 26.2 and everything seems to be working correctly. For the sake of my sanity, I'm not going to bother checking 26.1.2 and 1.21.11 because any potential errors should have occurred on the 26.2 servers. I have not yet checked the player tag fields, but it is very unlikely that they changed much given the size of the update. |
Jikoo
marked this pull request as ready for review
September 20, 2026 19:41
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For eager early adopters, dev builds are available from Actions runs on this PR. They are not tested. Please do not put them directly into a live server environment without verifying that they work first.