Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. WalkthroughThe change updates platform-specific dependencies, executable validation, shell error handling, and GitHub Actions versions for remote, device, and release jobs. ChangesDependency, executable, and CI maintenance
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Merge Risk: 🟠 High · up to The dependency and release-workflow changes can prevent builds from installing, expose write-capable credentials to a third-party build environment, and allow part of the build pipeline to fail without failing the job. These issues create concrete security and release-readiness risk, so the PR should not merge until they are fixed or explicitly accepted by the owner. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@Eeems or @Jayy001, I’m working on packaging codexctl for nix on macos. This pr would let me use remarkable-update-image 1.4.2 and its newer cryptography dependency while respecting codexctl’s declared requirements. failing jobs
The reMarkable failure looks like stale package indexes or an outdated build image investigated the intel failure. The dependency bump pulls in cryptography 50, which no longer ships intel macos wheels. CI builds it from source against Homebrew OpenSSL, then Nuitka 2.8.10 fails while packaging those external libraries. I tested a standalone intel build under Rosetta using this PR’s source, Nuitka 4.3.3, and real cryptography 50. Explicitly bundling OpenSSL’s libraries and legacy provider and configuring the provider location worked. With the original OpenSSL directories hidden, CLI help, SHA-256/AES-GCM/Blowfish checks, and generated firmware-fixture extraction all passed. Loader tracing confirmed it used the bundled libraries. Upgrading Nuitka alone avoided the scan error in a reduced test but still left the external dependency, so bundling matters too. The PR’s exact release build and native intel CI would still need validation. happy to help out further if you'd like. I don’t have an intel mac set up for testing right now, but could get an old macbook set up for this |
Summary by CodeRabbit