Repository navigation
Check custom alerts after several closes; draw Fibonacci retracements from 1 to 0 - #48
Merged
Merged
Conversation
The drawing tool put 0 at the first click and 1 at the second, the reverse of TradingView, MetaTrader and the app's own Auto Fib indicator. On a swing from 100 to 130 the line labelled 0.618 sat at 118.54, a 38.2% pullback. Now 1 is at the first point and 0 at the second, so a level reads as the share of the move given back; Reverse gives the old layout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
"Check after every" in the builder becomes three chips (daily, weekly,
monthly close); any of them can be ticked. The alert stays one rule:
editing, pausing and its watchlists apply to every interval.
- V101: custom_alerts.interval becomes an intervals array; states and
triggers gain an interval column, part of a trigger's key (a daily and
a weekly candle can share a timestamp). Existing alerts keep theirs.
- The engine runs each interval on its own candles with its own state per
stock; outcomes, baselines and the job queue follow the trigger's or
state's interval. A digest mixing intervals names each stock's.
- Pages show a stock's most telling state across the intervals and name
the intervals when it holds on only some ("Matches now · Weekly").
- Adding or dropping an interval is not a rule change: the kept intervals
go on, an added one gets its baseline, history stays.
- A condition's timeframe must not be shorter than any of the intervals.
- The preview tests one interval at a time, with a toggle when several
are ticked.
- The assistant drafts take "intervals" (a single "interval" still reads).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JanGradkowski
enabled auto-merge (squash)
November 8, 2026 15:31
aPrefetchWaitsForItsDownloadAndACheckArrivingMeanwhileJoinsIt released the download before the check asked for the same candles. A fast download thread then finished and left the in-flight map first, so the check started a second download (2 requests instead of 1). It failed CI on main on 7 November and on #48. The release now comes 300 ms after the check asks, when it is already waiting on the running download. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Custom alerts on several intervals. In the builder, "Check after every" is now three chips (daily, weekly, monthly close), and any of them can be ticked. It stays one alert: editing, pausing and its watchlists apply to every interval, and each trigger says which interval fired.
Fibonacci retracement direction. The drawing tool on the stock page now puts 1 at the first click (the swing start) and 0 at the second (its end). TradingView, MetaTrader and the app's own Auto Fib indicator all do it this way. Before, it was the other way round: on a swing from 100 to 130 the line labelled 0.618 sat at 118.54, which is a 38.2% pullback. "Reverse" now gives the old layout.
Custom alerts in detail
custom_alerts.intervalbecomes anintervalsarray (one to three of DAILY, WEEKLY, MONTHLY), and existing alerts keep their one interval. Per-stock states and triggers gain anintervalcolumn. It is part of each trigger's unique key, because a daily and a weekly candle can share a timestamp."intervals": [...], and a single"interval"is still read. The reference and recipes are updated.Testing
🤖 Generated with Claude Code