Fix config isolation, directional network metrics, and AeDebug launch - #22
Merged
Conversation
JamesLinYJ
marked this pull request as ready for review
August 17, 2026 16:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the root causes of all currently open issues found in the functional review:
Preferencesvalue, introduces a versioned taskmgr-rs-owned storage envelope, and performs only a narrowly identified one-time read-only migration from the legacy location.Root causes fixed
Configuration ownership
taskmgr-rs previously read and wrote its custom
Optionsbinary directly to the Microsoft Task Manager registry value. The new storage path is application-owned and versioned. The Microsoft value is never written or deleted; it is consulted only when its payload can be strongly identified as the current taskmgr-rs schema.Network utilization
MIB_IF_ROW2::TransmitLinkSpeedandReceiveLinkSpeedwere collapsed withmax()and reused as one denominator for Tx, Rx, and total traffic. That deterministically under-reported utilization on asymmetric links and gave the combined curve ambiguous full-duplex semantics. Tx/Rx now use their own capacities, while total is explicitly the maximum directional utilization.AeDebug launch semantics
The previous path reduced the AeDebug
Debuggervalue to its executable and reconstructed a generic-p <pid>command. The new path retains the validated template, expandsREG_EXPAND_SZ, chooses the target-specific registry view withIsWow64Process2, supports the two%ldAeDebug placeholders plus literal%%, rejects unsupported%ptemplates rather than inventing aJIT_DEBUG_INFOpointer, and usesPROC_THREAD_ATTRIBUTE_HANDLE_LISTso only the debugger-ready event is inherited.Automatic v0.2.6 release
This PR bumps the package version from
0.2.5to0.2.6in bothCargo.tomlandCargo.lockand updates the release documentation to match the repository's existing automation.After this PR is merged into
main,.github/workflows/release.ymlwill automatically:0.2.6and resolve release tagv0.2.6;SHA256SUMS.txtand GitHub build-provenance attestations;No manual
git tag/ tag push is required for this release. Future releases remain version-driven: intentionally bumpCargo.tomlandCargo.lock, then merge tomain; ordinary documentation or Dependabot merges do not create a new version by themselves.Validation
The final PR head passed the repository's formal Windows CI:
The existing release workflow has also previously completed its full verified publication path for
v0.2.5, including provenance, digest verification, and the final draft-to-published transition.Closes #19
Closes #20
Closes #21