Fix multi-pass tree reductions and matmul, vecdot strides in reductions - #3082
Merged
Merged
Conversation
ndgrigorian
requested review from
antonwolfy and
vlad-perevezentsev
as code owners
October 1, 2026 19:15
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev11=np2py314h8d9cdd5_18 ran successfully. |
Collaborator
|
coverage: 78.622% (+0.002%) from 78.62% — fix-tree-reductions into master |
antonwolfy
reviewed
Oct 2, 2026
antonwolfy
reviewed
Oct 2, 2026
ndgrigorian
changed the title
vecdot result stridesmatmul, vecdot strides in reductions
antonwolfy
approved these changes
Oct 2, 2026
antonwolfy
left a comment
antonwolfy
left a comment
Contributor
There was a problem hiding this comment.
Thank you @ndgrigorian
github-actions Bot
added a commit
that referenced
this pull request
Oct 2, 2026
…ctions (#3082) This PR fixes bugs in tree reductions, as well as a in `vecdot` for strided outputs * tree reductions which would take multiple passes over a row could, with very large rows, produce incorrect results * `vecdot` passed the strides of the second input as the strides of the output * A bug with GEMM kernels/`matmul` where intermediate reductions could use the wrong strides 6c3fca4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes bugs in tree reductions, as well as a in
vecdotfor strided outputsvecdotpassed the strides of the second input as the strides of the outputmatmulwhere intermediate reductions could use the wrong strides